From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42919 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7E7L-00065T-6m for qemu-devel@nongnu.org; Tue, 05 Apr 2011 17:48:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7E7J-0002a8-Cc for qemu-devel@nongnu.org; Tue, 05 Apr 2011 17:48:54 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:59993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7E7I-0002Ww-UJ for qemu-devel@nongnu.org; Tue, 05 Apr 2011 17:48:53 -0400 Subject: Re: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU From: Laurent Vivier In-Reply-To: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> References: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 05 Apr 2011 23:48:44 +0200 Message-ID: <1302040124.15215.5.camel@Quad> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Aurelien Jarno , Alexander Graf Le lundi 04 avril 2011 =C3=A0 12:09 +0100, Peter Maydell a =C3=A9crit : > CPU_QuadU isn't used on all targets, but there's no harm in defining the > typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because > softfloat-native doesn't have a float128 type. This avoids the need for > every new target which uses CPU_QuadU to add itself to an #ifdef in > what ought to be target-agnostic code. >=20 > Signed-off-by: Peter Maydell > --- > Noticed this one as a result of the s390 support patches; seems like > a minor but worthwhile cleanup to me... Sorry for the late comment, but I saw this rebasing my patchset on master... > cpu-all.h | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/cpu-all.h b/cpu-all.h > index 4cc445f..dc0f2f0 100644 > --- a/cpu-all.h > +++ b/cpu-all.h > @@ -138,11 +138,10 @@ typedef union { > uint64_t ll; > } CPU_DoubleU; > =20 > -#if defined(TARGET_SPARC) || defined(TARGET_S390X) > +#if defined(CONFIG_SOFTFLOAT) Why don't you use "#if defined(FLOAT128)" ? > typedef union { > float128 q; > -#if defined(HOST_WORDS_BIGENDIAN) \ > - || (defined(__arm__) && !defined(__VFP_FP__) && !defined(CONFIG_SOFT= FLOAT)) > +#if defined(HOST_WORDS_BIGENDIAN) > struct { > uint32_t upmost; > uint32_t upper; --=20 --------------------- laurent@vivier.eu ---------------------- "Tout ce qui est impossible reste =C3=A0 accomplir" Jules Verne "Things are only impossible until they're not" Jean-Luc Picard