From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33480 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7EXA-0007rW-Gc for qemu-devel@nongnu.org; Tue, 05 Apr 2011 18:15:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7EX9-0002fR-AC for qemu-devel@nongnu.org; Tue, 05 Apr 2011 18:15:36 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:51497) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7EX8-0002ev-TL for qemu-devel@nongnu.org; Tue, 05 Apr 2011 18:15:35 -0400 Subject: Re: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU From: Laurent Vivier In-Reply-To: References: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> <1302040124.15215.5.camel@Quad> Content-Type: text/plain; charset="UTF-8" Date: Wed, 06 Apr 2011 00:15:26 +0200 Message-ID: <1302041726.15215.10.camel@Quad> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Graf , qemu-devel@nongnu.org, Aurelien Jarno , Alexander@gnu.org Le mardi 05 avril 2011 =C3=A0 22:54 +0100, Peter Maydell a =C3=A9crit : > On 5 April 2011 22:48, Laurent Vivier wrote: > > Le lundi 04 avril 2011 =C3=A0 12:09 +0100, Peter Maydell a =C3=A9crit : > >> -#if defined(TARGET_SPARC) || defined(TARGET_S390X) > >> +#if defined(CONFIG_SOFTFLOAT) > > > > Why don't you use "#if defined(FLOAT128)" ? >=20 > I did consider that, but I felt FLOAT128 was a softfloat-internal > macro rather than part of the API softfloat provides to the rest > of qemu. But, for instance, "#ifdef FLOATX80" is used in target-i386/cpu.h and target-i386/op_helper.c. Regards, Laurent --=20 --------------------- laurent@vivier.eu ---------------------- "Tout ce qui est impossible reste =C3=A0 accomplir" Jules Verne "Things are only impossible until they're not" Jean-Luc Picard