From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36161 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7qUY-0005cw-5S for qemu-devel@nongnu.org; Thu, 07 Apr 2011 10:47:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7qUW-0004vd-Ru for qemu-devel@nongnu.org; Thu, 07 Apr 2011 10:47:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7qUW-0004vL-Hp for qemu-devel@nongnu.org; Thu, 07 Apr 2011 10:47:24 -0400 From: Kevin Wolf Date: Thu, 7 Apr 2011 16:49:23 +0200 Message-Id: <1302187764-16421-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1302187764-16421-1-git-send-email-kwolf@redhat.com> References: <1302187764-16421-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 14/15] Fix integer overflow in block migration bandwidth calculation List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Avishay Traeger block_mig_state.reads is an int, and multiplying by BLOCK_SIZE yielded a negative number, resulting in a negative bandwidth (running on a 32-bit machine). Change order to avoid. Signed-off-by: Avishay Traeger Signed-off-by: Kevin Wolf --- block-migration.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block-migration.c b/block-migration.c index 8218bac..576e55a 100644 --- a/block-migration.c +++ b/block-migration.c @@ -140,7 +140,7 @@ static inline void add_avg_read_time(int64_t time) static inline long double compute_read_bwidth(void) { assert(block_mig_state.total_time != 0); - return (block_mig_state.reads * BLOCK_SIZE)/ block_mig_state.total_time; + return (block_mig_state.reads / block_mig_state.total_time) * BLOCK_SIZE; } static int bmds_aio_inflight(BlkMigDevState *bmds, int64_t sector) -- 1.7.2.3