* [Qemu-devel] [PATCH] multiboot: Quote filename in error message.
@ 2011-04-08 6:48 Adam Lackorzynski
2011-04-08 7:40 ` [Qemu-devel] " Alexander Graf
2011-04-08 9:58 ` [Qemu-devel] " Stefan Hajnoczi
0 siblings, 2 replies; 6+ messages in thread
From: Adam Lackorzynski @ 2011-04-08 6:48 UTC (permalink / raw)
To: qemu-devel; +Cc: agraf
Quote filename in error message to spot possible whitespace character in
the filename and make error message more meaningful.
Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
---
hw/multiboot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 0d2bfb4..394ed01 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -272,7 +272,7 @@ int load_multiboot(void *fw_cfg,
mb_debug("multiboot loading module: %s\n", initrd_filename);
mb_mod_length = get_image_size(initrd_filename);
if (mb_mod_length < 0) {
- fprintf(stderr, "failed to get %s image size\n", initrd_filename);
+ fprintf(stderr, "Failed to open file '%s'\n", initrd_filename);
exit(1);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] multiboot: Quote filename in error message.
@ 2011-04-07 18:22 Adam Lackorzynski
2011-04-07 22:44 ` Alexander Graf
0 siblings, 1 reply; 6+ messages in thread
From: Adam Lackorzynski @ 2011-04-07 18:22 UTC (permalink / raw)
To: qemu-devel
Quote filename in error message to spot possible whitespace character in
the filename.
Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
---
hw/multiboot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 0d2bfb4..6be6fa0 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -272,7 +272,7 @@ int load_multiboot(void *fw_cfg,
mb_debug("multiboot loading module: %s\n", initrd_filename);
mb_mod_length = get_image_size(initrd_filename);
if (mb_mod_length < 0) {
- fprintf(stderr, "failed to get %s image size\n", initrd_filename);
+ fprintf(stderr, "failed to get image size of '%s'\n", initrd_filename);
exit(1);
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] multiboot: Quote filename in error message.
2011-04-07 18:22 Adam Lackorzynski
@ 2011-04-07 22:44 ` Alexander Graf
2011-04-08 6:48 ` Adam Lackorzynski
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Graf @ 2011-04-07 22:44 UTC (permalink / raw)
To: Adam Lackorzynski; +Cc: qemu-devel
On 07.04.2011, at 20:22, Adam Lackorzynski wrote:
> Quote filename in error message to spot possible whitespace character in
> the filename.
>
> Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
> ---
> hw/multiboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 0d2bfb4..6be6fa0 100644
> --- a/hw/multiboot.c
> +++ b/hw/multiboot.c
> @@ -272,7 +272,7 @@ int load_multiboot(void *fw_cfg,
> mb_debug("multiboot loading module: %s\n", initrd_filename);
> mb_mod_length = get_image_size(initrd_filename);
> if (mb_mod_length < 0) {
> - fprintf(stderr, "failed to get %s image size\n", initrd_filename);
> + fprintf(stderr, "failed to get image size of '%s'\n", initrd_filename);
I'd like to see something telling the user that the most likely reason is that the file isn't there :). It might even make sense to only say "Failed to open file '%s'".
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] multiboot: Quote filename in error message.
2011-04-07 22:44 ` Alexander Graf
@ 2011-04-08 6:48 ` Adam Lackorzynski
0 siblings, 0 replies; 6+ messages in thread
From: Adam Lackorzynski @ 2011-04-08 6:48 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-devel
On Fri Apr 08, 2011 at 00:44:36 +0200, Alexander Graf wrote:
>
> On 07.04.2011, at 20:22, Adam Lackorzynski wrote:
>
> > Quote filename in error message to spot possible whitespace character in
> > the filename.
> >
> > Signed-off-by: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
> > ---
> > hw/multiboot.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/hw/multiboot.c b/hw/multiboot.c
> > index 0d2bfb4..6be6fa0 100644
> > --- a/hw/multiboot.c
> > +++ b/hw/multiboot.c
> > @@ -272,7 +272,7 @@ int load_multiboot(void *fw_cfg,
> > mb_debug("multiboot loading module: %s\n", initrd_filename);
> > mb_mod_length = get_image_size(initrd_filename);
> > if (mb_mod_length < 0) {
> > - fprintf(stderr, "failed to get %s image size\n", initrd_filename);
> > + fprintf(stderr, "failed to get image size of '%s'\n", initrd_filename);
>
> I'd like to see something telling the user that the most likely reason is that the file isn't there :). It might even make sense to only say "Failed to open file '%s'".
Looking at get_image_size() it's the right thing to do...
Adam
--
Adam adam@os.inf.tu-dresden.de
Lackorzynski http://os.inf.tu-dresden.de/~adam/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-08 9:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-08 6:48 [Qemu-devel] [PATCH] multiboot: Quote filename in error message Adam Lackorzynski
2011-04-08 7:40 ` [Qemu-devel] " Alexander Graf
2011-04-08 9:58 ` [Qemu-devel] " Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2011-04-07 18:22 Adam Lackorzynski
2011-04-07 22:44 ` Alexander Graf
2011-04-08 6:48 ` Adam Lackorzynski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).