From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9wPf-0002iT-9C for qemu-devel@nongnu.org; Wed, 13 Apr 2011 05:31:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9wPZ-0004kC-Ie for qemu-devel@nongnu.org; Wed, 13 Apr 2011 05:31:03 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:62355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9wPZ-0004k1-Fa for qemu-devel@nongnu.org; Wed, 13 Apr 2011 05:30:57 -0400 Received: by yxk8 with SMTP id 8so229239yxk.4 for ; Wed, 13 Apr 2011 02:30:56 -0700 (PDT) From: Mitnick Lyu Date: Wed, 13 Apr 2011 17:30:54 +0800 Message-Id: <1302687054-16675-1-git-send-email-mitnick.lyu@gmail.com> Subject: [Qemu-devel] [PATCH] vpc.c: Use get_option_parameter() does the search List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@gmail.com, Mitnick Lyu Use get_option_parameter() to instead of duplicating the loop, and use BDRV_SECTOR_SIZE to instead of 512 Signed-off-by: Mitnick Lyu --- block/vpc.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 7b025be..56865da 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -505,12 +505,8 @@ static int vpc_create(const char *filename, QEMUOptionParameter *options) int ret = -EIO; // Read out options - while (options && options->name) { - if (!strcmp(options->name, "size")) { - total_sectors = options->value.n / 512; - } - options++; - } + total_sectors = get_option_parameter(options, BLOCK_OPT_SIZE)->value.n / + BDRV_SECTOR_SIZE; // Create the file fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, 0644); -- 1.7.0.4