qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 05/10] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change
Date: Wed, 13 Apr 2011 14:05:11 +0200	[thread overview]
Message-ID: <1302696316-26190-6-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1302696316-26190-1-git-send-email-kwolf@redhat.com>

From: Amit Shah <amit.shah@redhat.com>

After a media change, the only commands allowed from the guest were
REQUEST_SENSE and INQUIRY.  The guest may also issue
GET_EVENT_STATUS_NOTIFICATION commands to get media
changed notification.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/ide/core.c |   20 ++++++++++++++------
 1 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index b5de22e..f0da95d 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1102,13 +1102,21 @@ static void ide_atapi_cmd(IDEState *s)
         printf("\n");
     }
 #endif
-    /* If there's a UNIT_ATTENTION condition pending, only
-       REQUEST_SENSE and INQUIRY commands are allowed to complete. */
+    /*
+     * If there's a UNIT_ATTENTION condition pending, only
+     * REQUEST_SENSE, INQUIRY, GET_CONFIGURATION and
+     * GET_EVENT_STATUS_NOTIFICATION commands are allowed to complete.
+     * MMC-5, section 4.1.6.1 lists only these commands being allowed
+     * to complete, with other commands getting a CHECK condition
+     * response unless a higher priority status, defined by the drive
+     * here, is pending.
+     */
     if (s->sense_key == SENSE_UNIT_ATTENTION &&
-	s->io_buffer[0] != GPCMD_REQUEST_SENSE &&
-	s->io_buffer[0] != GPCMD_INQUIRY) {
-	ide_atapi_cmd_check_status(s);
-	return;
+        s->io_buffer[0] != GPCMD_REQUEST_SENSE &&
+        s->io_buffer[0] != GPCMD_INQUIRY &&
+        s->io_buffer[0] != GPCMD_GET_EVENT_STATUS_NOTIFICATION) {
+        ide_atapi_cmd_check_status(s);
+        return;
     }
     switch(s->io_buffer[0]) {
     case GPCMD_TEST_UNIT_READY:
-- 
1.7.2.3

  parent reply	other threads:[~2011-04-13 12:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 12:05 [Qemu-devel] [PULL 00/10] Block patches Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 01/10] docs: Describe zero data clusters in QED specification Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 02/10] qed: Add support for zero clusters Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 03/10] atapi: Drives can be locked without media present Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 04/10] atapi: Report correct errors on guest eject request Kevin Wolf
2011-04-13 12:05 ` Kevin Wolf [this message]
2011-04-13 12:05 ` [Qemu-devel] [PATCH 06/10] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 07/10] atapi: GESN: Use structs for commonly-used field types Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 08/10] atapi: GESN: Standardise event response handling for future additions Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 09/10] atapi: GESN: implement 'media' subcommand Kevin Wolf
2011-04-13 12:05 ` [Qemu-devel] [PATCH 10/10] vpc.c: Use get_option_parameter() does the search Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1302696316-26190-6-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).