From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPzI-00012o-5q for qemu-devel@nongnu.org; Mon, 25 Apr 2011 13:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QEPzH-0008CJ-8L for qemu-devel@nongnu.org; Mon, 25 Apr 2011 13:54:20 -0400 Received: from mail-wy0-f195.google.com ([74.125.82.195]:56920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QEPzH-0008C6-49 for qemu-devel@nongnu.org; Mon, 25 Apr 2011 13:54:19 -0400 Received: by wyb32 with SMTP id 32so382753wyb.10 for ; Mon, 25 Apr 2011 10:54:17 -0700 (PDT) From: Sassan Panahinejad Date: Mon, 25 Apr 2011 18:54:05 +0100 Message-Id: <1303754045-19635-1-git-send-email-sassan@sassan.me.uk> Subject: [Qemu-devel] [PATCH] Fix bug with virtio-9p fsync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Sassan Panahinejad v9fs_fsync and possibly others break when asked to operate on a directory. It does not check fid_type to see if it is operating on a directory and therefore accesses the wrong element of the fs union. This error can result in guest applications failing (in my case it was dpkg). This patch fixes the issue, although there may be other, similar bugs in virtio-9p. --- hw/virtio-9p.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c index 7e29535..09fb5da 100644 --- a/hw/virtio-9p.c +++ b/hw/virtio-9p.c @@ -1875,7 +1875,10 @@ static void v9fs_fsync(V9fsState *s, V9fsPDU *pdu) v9fs_post_do_fsync(s, pdu, err); return; } - err = v9fs_do_fsync(s, fidp->fs.fd, datasync); + if (fidp->fid_type == P9_FID_DIR) + err = v9fs_do_fsync(s, dirfd(fidp->fs.dir), datasync); + else + err = v9fs_do_fsync(s, fidp->fs.fd, datasync); v9fs_post_do_fsync(s, pdu, err); } -- 1.7.0.4