qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/6] docs: Trace events must not expect pointer dereferencing
Date: Tue, 26 Apr 2011 13:26:00 +0100	[thread overview]
Message-ID: <1303820763-6720-4-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1303820763-6720-1-git-send-email-stefanha@linux.vnet.ibm.com>

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 docs/tracing.txt |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/docs/tracing.txt b/docs/tracing.txt
index f15069c..905a083 100644
--- a/docs/tracing.txt
+++ b/docs/tracing.txt
@@ -69,6 +69,11 @@ Trace events should use types as follows:
    cannot include all user-defined struct declarations and it is therefore
    necessary to use void * for pointers to structs.
 
+   Pointers (including char *) cannot be dereferenced easily (or at all) in
+   some trace backends.  If pointers are used, ensure they are meaningful by
+   themselves and do not assume the data they point to will be traced.  Do
+   not pass in string arguments.
+
  * For everything else, use primitive scalar types (char, int, long) with the
    appropriate signedness.
 
-- 
1.7.4.1

  parent reply	other threads:[~2011-04-26 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 12:25 [Qemu-devel] [PULL 0/6] Tracing patches Stefan Hajnoczi
2011-04-26 12:25 ` [Qemu-devel] [PATCH 1/6] tracetool: allow ) in trace output string Stefan Hajnoczi
2011-04-26 12:25 ` [Qemu-devel] [PATCH 2/6] trace: Remove %s in grlib trace events Stefan Hajnoczi
2011-04-26 12:26 ` Stefan Hajnoczi [this message]
2011-04-26 12:26 ` [Qemu-devel] [PATCH 4/6] docs/tracing.txt: minor documentation fixes Stefan Hajnoczi
2011-04-26 20:46   ` Brad Hards
2011-04-26 21:00     ` [Qemu-devel] " Mike D. Day
2011-04-26 12:26 ` [Qemu-devel] [PATCH 5/6] trace: [ust] fix generation of 'trace.c' on events without args Stefan Hajnoczi
2011-04-26 12:26 ` [Qemu-devel] [PATCH 6/6] trace: [trace-events] fix print formats in some events Stefan Hajnoczi
2011-04-26 13:19 ` [Qemu-devel] [PULL 0/6] Tracing patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303820763-6720-4-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).