From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 10/11] Add dd-style SIGUSR1 progress reporting
Date: Wed, 27 Apr 2011 15:43:09 +0200 [thread overview]
Message-ID: <1303911790-27422-11-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1303911790-27422-1-git-send-email-kwolf@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
This introduces support for dd-style progress reporting on POSIX
systems, if the user hasn't specified -p to report progress. If sent a
SIGUSR1, qemu-img will report current progress for commands that
support progress reporting.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-progress.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++-----
1 files changed, 48 insertions(+), 5 deletions(-)
diff --git a/qemu-progress.c b/qemu-progress.c
index 656e065..b4b751c 100644
--- a/qemu-progress.c
+++ b/qemu-progress.c
@@ -26,12 +26,15 @@
#include "osdep.h"
#include "sysemu.h"
#include <stdio.h>
+#include <signal.h>
struct progress_state {
int enabled;
float current;
float last_print;
float min_skip;
+ void (*print)(void);
+ void (*end)(void);
};
static struct progress_state state;
@@ -51,20 +54,60 @@ static void progress_simple_print(void)
static void progress_simple_end(void)
{
- if (state.enabled) {
- printf("\n");
- }
+ printf("\n");
+}
+
+static void progress_simple_init(void)
+{
+ state.print = progress_simple_print;
+ state.end = progress_simple_end;
+}
+
+#ifdef CONFIG_POSIX
+static void sigusr_print(int signal)
+{
+ printf(" (%3.2f/100%%)\n", state.current);
+}
+#endif
+
+static void progress_dummy_print(void)
+{
+}
+
+static void progress_dummy_end(void)
+{
+}
+
+static void progress_dummy_init(void)
+{
+#ifdef CONFIG_POSIX
+ struct sigaction action;
+
+ memset(&action, 0, sizeof(action));
+ sigfillset(&action.sa_mask);
+ action.sa_handler = sigusr_print;
+ action.sa_flags = 0;
+ sigaction(SIGUSR1, &action, NULL);
+#endif
+
+ state.print = progress_dummy_print;
+ state.end = progress_dummy_end;
}
void qemu_progress_init(int enabled, float min_skip)
{
state.enabled = enabled;
state.min_skip = min_skip;
+ if (enabled) {
+ progress_simple_init();
+ } else {
+ progress_dummy_init();
+ }
}
void qemu_progress_end(void)
{
- progress_simple_end();
+ state.end();
}
void qemu_progress_print(float percent, int max)
@@ -84,6 +127,6 @@ void qemu_progress_print(float percent, int max)
if (current > (state.last_print + state.min_skip) ||
(current == 100) || (current == 0)) {
state.last_print = state.current;
- progress_simple_print();
+ state.print();
}
}
--
1.7.2.3
next prev parent reply other threads:[~2011-04-27 13:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 13:42 [Qemu-devel] [PULL 00/11] Block patches Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 01/11] qemu-img: allow rebase to a NULL backing file when unsafe Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 02/11] atapi: Add 'medium ready' to 'medium not ready' transition on cd change Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 03/11] Improve accuracy of block migration bandwidth calculation Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 04/11] ide: Split atapi.c out Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 05/11] ide/atapi: Factor commands out Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 06/11] ide/atapi: Use table instead of switch for commands Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 07/11] ide/atapi: Replace bdrv_get_geometry calls by s->nb_sectors Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 08/11] ide/atapi: Introduce CHECK_READY flag for commands Kevin Wolf
2011-04-27 13:43 ` [Qemu-devel] [PATCH 09/11] qed: Fix consistency check on 32-bit hosts Kevin Wolf
2011-04-27 13:43 ` Kevin Wolf [this message]
2011-04-27 13:43 ` [Qemu-devel] [PATCH 11/11] Remove obsolete 'enabled' variable from progress state Kevin Wolf
2011-04-27 14:26 ` [Qemu-devel] [PULL 00/11] Block patches Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303911790-27422-11-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).