From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGGxz-0006PH-In for qemu-devel@nongnu.org; Sat, 30 Apr 2011 16:40:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QGGxy-0000W8-Jt for qemu-devel@nongnu.org; Sat, 30 Apr 2011 16:40:39 -0400 Received: from moutng.kundenserver.de ([212.227.17.10]:58395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGGxy-0000Vy-5l for qemu-devel@nongnu.org; Sat, 30 Apr 2011 16:40:38 -0400 From: Stefan Weil Date: Sat, 30 Apr 2011 22:40:05 +0200 Message-Id: <1304196013-14432-3-git-send-email-weil@mail.berlios.de> In-Reply-To: <1304196013-14432-1-git-send-email-weil@mail.berlios.de> References: <1304196013-14432-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH v2 02/10] eepro100: Remove type casts which are no longer needed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: QEMU Developers Signed-off-by: Stefan Weil --- hw/eepro100.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index cbbaf14..0e22d91 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -311,7 +311,7 @@ static const uint16_t eepro100_mdi_mask[] = { static void stl_le_phys(target_phys_addr_t addr, uint32_t val) { val = cpu_to_le32(val); - cpu_physical_memory_write(addr, (const uint8_t *)&val, sizeof(val)); + cpu_physical_memory_write(addr, &val, sizeof(val)); } #define POLYNOMIAL 0x04c11db6 @@ -694,8 +694,7 @@ static void dump_statistics(EEPRO100State * s) * values which really matter. * Number of data should check configuration!!! */ - cpu_physical_memory_write(s->statsaddr, - (uint8_t *) & s->statistics, s->stats_size); + cpu_physical_memory_write(s->statsaddr, &s->statistics, s->stats_size); stl_le_phys(s->statsaddr + 0, s->statistics.tx_good_frames); stl_le_phys(s->statsaddr + 36, s->statistics.rx_good_frames); stl_le_phys(s->statsaddr + 48, s->statistics.rx_resource_errors); @@ -709,7 +708,7 @@ static void dump_statistics(EEPRO100State * s) static void read_cb(EEPRO100State *s) { - cpu_physical_memory_read(s->cb_address, (uint8_t *) &s->tx, sizeof(s->tx)); + cpu_physical_memory_read(s->cb_address, &s->tx, sizeof(s->tx)); s->tx.status = le16_to_cpu(s->tx.status); s->tx.command = le16_to_cpu(s->tx.command); s->tx.link = le32_to_cpu(s->tx.link); @@ -1268,10 +1267,10 @@ static void eepro100_write_port(EEPRO100State * s, uint32_t val) case PORT_SELFTEST: TRACE(OTHER, logout("selftest address=0x%08x\n", address)); eepro100_selftest_t data; - cpu_physical_memory_read(address, (uint8_t *) & data, sizeof(data)); + cpu_physical_memory_read(address, &data, sizeof(data)); data.st_sign = 0xffffffff; data.st_result = 0; - cpu_physical_memory_write(address, (uint8_t *) & data, sizeof(data)); + cpu_physical_memory_write(address, &data, sizeof(data)); break; case PORT_SELECTIVE_RESET: TRACE(OTHER, logout("selective reset, selftest address=0x%08x\n", address)); @@ -1738,7 +1737,7 @@ static ssize_t nic_receive(VLANClientState *nc, const uint8_t * buf, size_t size } /* !!! */ eepro100_rx_t rx; - cpu_physical_memory_read(s->ru_base + s->ru_offset, (uint8_t *) & rx, + cpu_physical_memory_read(s->ru_base + s->ru_offset, &rx, offsetof(eepro100_rx_t, packet)); uint16_t rfd_command = le16_to_cpu(rx.command); uint16_t rfd_size = le16_to_cpu(rx.size); -- 1.7.2.5