From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH 4/4] fix compilation when reconfiguring without dtrace backend
Date: Mon, 2 May 2011 09:54:06 +0200 [thread overview]
Message-ID: <1304322846-24376-4-git-send-email-pbonzini@redhat.com> (raw)
If QEMU is configured with the dtrace backend, then built, then
reconfigured without, the build fails.
The culprit is the trace-dtrace.h dependency that many files will
have. Due to this dependency, make will attempt to rebuild
trace-dtrace.dtrace. This is the step that fails. Fix by wrapping
the dtrace rules with ifeq/endif.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org
---
Makefile.objs | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile.objs b/Makefile.objs
index 0ba989f..e4e538a 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -326,6 +326,7 @@ trace.c-timestamp: $(SRC_PATH)/trace-events config-host.mak
trace.o: trace.c $(GENERATED_HEADERS)
+ifeq ($(TRACE_BACKEND),dtrace)
trace-dtrace.h: trace-dtrace.dtrace
$(call quiet-command,dtrace -o $@ -h -s $<, " GEN trace-dtrace.h")
@@ -339,6 +340,7 @@ trace-dtrace.dtrace-timestamp: $(SRC_PATH)/trace-events config-host.mak
trace-dtrace.o: trace-dtrace.dtrace $(GENERATED_HEADERS)
$(call quiet-command,dtrace -o $@ -G -s $<, " GEN trace-dtrace.o")
+endif
simpletrace.o: simpletrace.c $(GENERATED_HEADERS)
--
1.7.4.4
next reply other threads:[~2011-05-02 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 7:54 Paolo Bonzini [this message]
2011-05-08 11:15 ` [Qemu-devel] [Qemu-trivial] [PATCH 4/4] fix compilation when reconfiguring without dtrace backend Stefan Hajnoczi
2011-05-09 6:53 ` Paolo Bonzini
2011-05-09 8:34 ` Stefan Hajnoczi
2011-05-09 8:42 ` Paolo Bonzini
2011-05-09 9:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304322846-24376-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).