From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGpHq-0001XT-Ix for qemu-devel@nongnu.org; Mon, 02 May 2011 05:19:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QGpHp-0006f5-If for qemu-devel@nongnu.org; Mon, 02 May 2011 05:19:26 -0400 Received: from afflict.kos.to ([92.243.29.197]:56824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QGpHp-0006e8-E7 for qemu-devel@nongnu.org; Mon, 02 May 2011 05:19:25 -0400 From: riku.voipio@iki.fi Date: Mon, 2 May 2011 12:19:09 +0300 Message-Id: <1304327950-21422-3-git-send-email-riku.voipio@iki.fi> In-Reply-To: <1304327950-21422-1-git-send-email-riku.voipio@iki.fi> References: <1304327950-21422-1-git-send-email-riku.voipio@iki.fi> Subject: [Qemu-devel] [PATCH 2/3] Fix buffer overrun in sched_getaffinity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Mike McCormack , Riku Voipio From: Mike McCormack Zeroing of the cpu array should start from &cpus[kernel_ret] not &cpus[num_zeros_to_fill]. This fixes a crash in EFL's edje_cc running under qemu-arm. Signed-off-by: Mike McCormack Reviewed-by: Stefan Hajnoczi Acked-by: Mike Frysinger Signed-off-by: Riku Voipio --- linux-user/syscall.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e969d1b..5b7b8e2 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6505,7 +6505,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, unsigned long zero = arg2 - ret; p = alloca(zero); memset(p, 0, zero); - if (copy_to_user(arg3 + zero, p, zero)) { + if (copy_to_user(arg3 + ret, p, zero)) { goto efault; } arg2 = ret; -- 1.7.4.1