From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHDQU-0001Hl-Kp for qemu-devel@nongnu.org; Tue, 03 May 2011 07:05:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHDQT-0005Q8-Nj for qemu-devel@nongnu.org; Tue, 03 May 2011 07:05:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31710) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHDQT-0005Q2-FS for qemu-devel@nongnu.org; Tue, 03 May 2011 07:05:57 -0400 From: Kevin Wolf Date: Tue, 3 May 2011 13:08:25 +0200 Message-Id: <1304420906-5776-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1304420906-5776-1-git-send-email-kwolf@redhat.com> References: <1304420906-5776-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 5/6] qemu-progress.c: printf isn't signal safe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Jes Sorensen Change the signal handling to indicate a signal is pending, rather then printing directly from the signal handler. In addition make the signal prints go to stderr, rather than stdout. Signed-off-by: Jes Sorensen Signed-off-by: Kevin Wolf --- qemu-progress.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/qemu-progress.c b/qemu-progress.c index e1feb89..a4894c0 100644 --- a/qemu-progress.c +++ b/qemu-progress.c @@ -37,6 +37,7 @@ struct progress_state { }; static struct progress_state state; +static volatile sig_atomic_t print_pending; /* * Simple progress print function. @@ -63,12 +64,16 @@ static void progress_simple_init(void) #ifdef CONFIG_POSIX static void sigusr_print(int signal) { - printf(" (%3.2f/100%%)\n", state.current); + print_pending = 1; } #endif static void progress_dummy_print(void) { + if (print_pending) { + fprintf(stderr, " (%3.2f/100%%)\n", state.current); + print_pending = 0; + } } static void progress_dummy_end(void) -- 1.7.2.3