From: Alexander Graf <agraf@suse.de>
To: QEMU-devel Developers <qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, jan.kiszka@siemens.com,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 04/13] s390x: keep hint on virtio managing size
Date: Wed, 4 May 2011 14:09:33 +0200 [thread overview]
Message-ID: <1304510982-30810-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1304510982-30810-1-git-send-email-agraf@suse.de>
The s390x virtio bus keeps management information on virtio after the top
of the guest's RAM. We need to be able to tell the guest the size of its
RAM (without virtio stuff), but also be able to trap when the guest accesses
RAM outside of its scope (including virtio stuff).
So we need a variable telling us the size of the virtio stuff, so we can
calculate the highest available RAM address from that.
While at it, also increase the maximum number of virtio pages, so we play
along well with more recent kernels that spawn a ridiculous number of virtio
console adapters.
Signed-off-by: Alexander Graf <agraf@suse.de>
---
v4 -> v5:
- make virtio_size const
---
hw/s390-virtio-bus.c | 3 +++
hw/s390-virtio-bus.h | 2 +-
target-s390x/cpu.h | 3 +++
3 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c
index bb49e39..d4a12f7 100644
--- a/hw/s390-virtio-bus.c
+++ b/hw/s390-virtio-bus.c
@@ -60,6 +60,9 @@ static const VirtIOBindings virtio_s390_bindings;
static ram_addr_t s390_virtio_device_num_vq(VirtIOS390Device *dev);
+/* length of VirtIO device pages */
+const target_phys_addr_t virtio_size = S390_DEVICE_PAGES * TARGET_PAGE_SIZE;
+
VirtIOS390Bus *s390_virtio_bus_init(ram_addr_t *ram_size)
{
VirtIOS390Bus *bus;
diff --git a/hw/s390-virtio-bus.h b/hw/s390-virtio-bus.h
index edf6d04..0c412d0 100644
--- a/hw/s390-virtio-bus.h
+++ b/hw/s390-virtio-bus.h
@@ -33,7 +33,7 @@
#define VIRTIO_VQCONFIG_LEN 24
#define VIRTIO_RING_LEN (TARGET_PAGE_SIZE * 3)
-#define S390_DEVICE_PAGES 256
+#define S390_DEVICE_PAGES 512
typedef struct VirtIOS390Device {
DeviceState qdev;
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index 79aa6c9..00939a3 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -310,6 +310,9 @@ static inline void kvm_s390_interrupt_internal(CPUState *env, int type,
#endif
CPUState *s390_cpu_addr2state(uint16_t cpu_addr);
+/* from s390-virtio-bus */
+extern const target_phys_addr_t virtio_size;
+
#ifndef KVM_S390_SIGP_STOP
#define KVM_S390_SIGP_STOP 0
#define KVM_S390_PROGRAM_INT 0
--
1.6.0.2
next prev parent reply other threads:[~2011-05-04 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 12:09 [Qemu-devel] [PATCH 00/13] s390x emulation support v5 Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 01/13] tcg: extend max tcg opcodes when using 64-on-32bit Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 02/13] s390x: s390x-linux-user support Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 03/13] s390x: make kvm exported functions conditional on kvm Alexander Graf
2011-05-04 12:09 ` Alexander Graf [this message]
2011-05-04 12:09 ` [Qemu-devel] [PATCH 05/13] s390x: Shift variables in CPUState for memset(0) Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 06/13] s390x: helper functions for system emulation Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 07/13] s390x: Implement opcode helpers Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 08/13] s390x: Adjust internal kvm code Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 09/13] s390x: translate engine for s390x CPU Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 10/13] s390x: Adjust GDB stub Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 11/13] s390x: remove compatibility cc field Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 12/13] s390x: build s390x by default Alexander Graf
2011-05-04 12:09 ` [Qemu-devel] [PATCH 13/13] s390x: Fix debugging for unknown sigp order codes Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304510982-30810-5-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).