From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHeDA-0008DU-5F for qemu-devel@nongnu.org; Wed, 04 May 2011 11:42:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHeD8-0007JE-8V for qemu-devel@nongnu.org; Wed, 04 May 2011 11:41:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHeD7-0007Il-WF for qemu-devel@nongnu.org; Wed, 04 May 2011 11:41:58 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p44FfvZ4031762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 4 May 2011 11:41:57 -0400 From: Gerd Hoffmann Date: Wed, 4 May 2011 17:41:39 +0200 Message-Id: <1304523708-9556-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1304523708-9556-1-git-send-email-kraxel@redhat.com> References: <1304523708-9556-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 05/14] usb-linux: Refuse iso packets when max packet size is 0 (alt setting 0) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Gerd Hoffmann From: Hans de Goede Refuse iso usb packets when then max packet size for the endpoint is 0, this avoids an abort in usb_host_alloc_iso() caused by trying to qemu_malloc a 0 bytes large buffer. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 6aef7a5..4c42fe1 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -549,7 +549,11 @@ static int urb_status_to_usb_ret(int status) static int usb_host_handle_iso_data(USBHostDevice *s, USBPacket *p) { AsyncURB *aurb; - int i, j, ret, len = 0; + int i, j, ret, max_packet_size, len = 0; + + max_packet_size = get_max_packet_size(s, p->devep); + if (max_packet_size == 0) + return USB_RET_NAK; aurb = get_iso_urb(s, p->devep); if (!aurb) { -- 1.7.1