From: <anthony.perard@citrix.com>
To: QEMU-devel <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Alexander Graf <agraf@suse.de>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
John Baboval <john.baboval@virtualcomputer.com>,
Xen Devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [Qemu-devel] [PATCH V15 14/18] pci: Use of qemu_put_ram_ptr in pci_add_option_rom.
Date: Thu, 5 May 2011 11:58:29 +0100 [thread overview]
Message-ID: <1304593113-10689-15-git-send-email-anthony.perard@citrix.com> (raw)
In-Reply-To: <1304593113-10689-1-git-send-email-anthony.perard@citrix.com>
From: John Baboval <john.baboval@virtualcomputer.com>
Prevent a deadlock caused by leaving a map cache bucket locked by the
preceding qemu_get_ram_ptr() call.
Signed-off-By: John Baboval <john.baboval@virtualcomputer.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
hw/pci.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 6b577e1..2b24dd4 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1897,6 +1897,8 @@ static int pci_add_option_rom(PCIDevice *pdev, bool is_default_rom)
pci_patch_ids(pdev, ptr, size);
}
+ qemu_put_ram_ptr(ptr);
+
pci_register_bar(pdev, PCI_ROM_SLOT, size,
0, pci_map_option_rom);
--
1.7.2.5
next prev parent reply other threads:[~2011-05-05 10:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 10:58 [Qemu-devel] [PATCH V15 00/18] Xen device model support anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 01/18] xen: Replace some tab-indents with spaces (clean-up) anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 02/18] xen: Make Xen build once anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 03/18] xen: Support new libxc calls from xen unstable anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 04/18] xen: Add initialisation of Xen anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 05/18] pc_memory_init: Move memory calculation to the caller anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 06/18] xen: Add xenfv machine anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 07/18] pc, Disable vmport initialisation with Xen anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 08/18] piix_pci: Introduces Xen specific call for irq anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 09/18] xen: Introduce Xen Interrupt Controller anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 10/18] xen: Introduce the Xen mapcache anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 11/18] xen: Adds a cap to the number of map cache entries anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 12/18] Introduce qemu_put_ram_ptr anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 13/18] configure: Always use 64bits target physical addresses with xen enabled anthony.perard
2011-05-05 10:58 ` anthony.perard [this message]
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 15/18] vl.c: Introduce getter for shutdown_requested and reset_requested anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 16/18] xen: Initialize event channels and io rings anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 17/18] xen: Set running state in xenstore anthony.perard
2011-05-05 10:58 ` [Qemu-devel] [PATCH V15 18/18] xen: Add Xen hypercall for sleep state in the cmos_s3 callback anthony.perard
2011-05-09 13:58 ` [Qemu-devel] [PATCH V15 00/18] Xen device model support Alexander Graf
2011-05-09 14:28 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304593113-10689-15-git-send-email-anthony.perard@citrix.com \
--to=anthony.perard@citrix.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=john.baboval@virtualcomputer.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).