From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck)
Date: Sat, 7 May 2011 22:23:49 +0200 [thread overview]
Message-ID: <1304799829-19555-1-git-send-email-weil@mail.berlios.de> (raw)
cppcheck report:
virtio-9p.c:197: warning: Redundant assignment of "flags" to itself
Cc: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
hw/9pfs/virtio-9p.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index ac5a1d0..d31b34a 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -194,7 +194,6 @@ static int v9fs_do_open2(V9fsState *s, char *fullname, uid_t uid, gid_t gid,
cred.fc_uid = uid;
cred.fc_gid = gid;
cred.fc_mode = mode & 07777;
- flags = flags;
return s->ops->open2(&s->ctx, fullname, flags, &cred);
}
--
1.7.2.5
next reply other threads:[~2011-05-07 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 20:23 Stefan Weil [this message]
2011-05-08 17:17 ` [Qemu-devel] [PATCH] virtio-9p: Remove statement without effect (fix warning from cppcheck) Venkateswararao Jujjuri
2011-06-03 21:39 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304799829-19555-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=jvrao@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).