From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIoMH-0007di-LJ for qemu-devel@nongnu.org; Sat, 07 May 2011 16:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QIoMG-00071l-O9 for qemu-devel@nongnu.org; Sat, 07 May 2011 16:44:13 -0400 Received: from moutng.kundenserver.de ([212.227.17.9]:52776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIoMG-00071e-AB for qemu-devel@nongnu.org; Sat, 07 May 2011 16:44:12 -0400 From: Stefan Weil Date: Sat, 7 May 2011 22:44:08 +0200 Message-Id: <1304801048-26036-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] linux-user: Set uninitialized local variable and disable unused code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Riku Voipio cppcheck report: linux-user/signal.c:2057: error: Uninitialized variable: err cppcheck is correct. Setting err = 0 is a workaround to avoid random results and the cppcheck warning. Function restore_fpu_state is currently unused, so I disabled the code. Signed-off-by: Stefan Weil --- linux-user/signal.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index ce033e9..4bda475 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2027,6 +2027,8 @@ sigsegv: unlock_user(sf, sf_addr, sizeof(struct target_signal_frame)); force_sig(TARGET_SIGSEGV); } + +#if 0 /* TODO: function is unused */ static inline int restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu) { @@ -2053,6 +2055,8 @@ restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu) /* XXX: incorrect */ err = __copy_from_user(&env->fpr[0], &fpu->si_float_regs[0], (sizeof(unsigned long) * 32)); +#else + err = 0; #endif err |= __get_user(env->fsr, &fpu->si_fsr); #if 0 @@ -2065,7 +2069,7 @@ restore_fpu_state(CPUState *env, qemu_siginfo_fpu_t *fpu) #endif return err; } - +#endif static void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, -- 1.7.2.5