qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Hannes Reinecke <hare@suse.de>
Subject: [Qemu-devel] [PATCH 24/24] lsi53c895a: Rename 'sense' to 'status'
Date: Sun,  8 May 2011 17:05:19 +0100	[thread overview]
Message-ID: <1304870719-20885-25-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1304870719-20885-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Hannes Reinecke <hare@suse.de>

The 'sense' field in the HBA status structure is misnamed, as it
actually carries the SCSI status. Rename it.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/lsi53c895a.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index be4df58..2ce38a9 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -189,7 +189,7 @@ typedef struct {
     uint32_t script_ram_base;
 
     int carry; /* ??? Should this be an a visible register somewhere?  */
-    int sense;
+    int status;
     /* Action to take at the end of a MSG IN phase.
        0 = COMMAND, 1 = disconnect, 2 = DATA OUT, 3 = DATA IN.  */
     int msg_action;
@@ -695,8 +695,8 @@ static void lsi_command_complete(SCSIBus *bus, int reason, uint32_t tag,
 
     out = (s->sstat1 & PHASE_MASK) == PHASE_DO;
     if (reason == SCSI_REASON_DONE) {
-        DPRINTF("Command complete sense=%d\n", (int)arg);
-        s->sense = arg;
+        DPRINTF("Command complete status=%d\n", (int)arg);
+        s->status = arg;
         s->command_complete = 2;
         if (s->waiting && s->dbc != 0) {
             /* Raise phase mismatch for short transfers.  */
@@ -783,14 +783,14 @@ static void lsi_do_command(LSIState *s)
 
 static void lsi_do_status(LSIState *s)
 {
-    uint8_t sense;
-    DPRINTF("Get status len=%d sense=%d\n", s->dbc, s->sense);
+    uint8_t status;
+    DPRINTF("Get status len=%d status=%d\n", s->dbc, s->status);
     if (s->dbc != 1)
         BADF("Bad Status move\n");
     s->dbc = 1;
-    sense = s->sense;
-    s->sfbr = sense;
-    cpu_physical_memory_write(s->dnad, &sense, 1);
+    status = s->status;
+    s->sfbr = status;
+    cpu_physical_memory_write(s->dnad, &status, 1);
     lsi_set_phase(s, PHASE_MI);
     s->msg_action = 1;
     lsi_add_msg_byte(s, 0); /* COMMAND COMPLETE */
@@ -2122,7 +2122,7 @@ static const VMStateDescription vmstate_lsi_scsi = {
         VMSTATE_PCI_DEVICE(dev, LSIState),
 
         VMSTATE_INT32(carry, LSIState),
-        VMSTATE_INT32(sense, LSIState),
+        VMSTATE_INT32(status, LSIState),
         VMSTATE_INT32(msg_action, LSIState),
         VMSTATE_INT32(msg_len, LSIState),
         VMSTATE_BUFFER(msg, LSIState),
-- 
1.7.4.4

  parent reply	other threads:[~2011-05-08 16:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-08 16:04 [Qemu-devel] [PULL] Trivial patches for April 26 to May 8 2011 Stefan Hajnoczi
2011-05-08 16:04 ` [Qemu-devel] [PATCH 01/24] Fix typo in code and comments Stefan Hajnoczi
2011-05-08 16:04 ` [Qemu-devel] [PATCH 02/24] Fix typos in comments (dependancy -> dependency) Stefan Hajnoczi
2011-05-08 16:04 ` [Qemu-devel] [PATCH 03/24] Fix typos in comments (accross -> across) Stefan Hajnoczi
2011-05-08 16:04 ` [Qemu-devel] [PATCH 04/24] Fix typos in comments (accessable -> accessible, priveleged -> privileged) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 05/24] Fix typo in comment (colum -> column) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 06/24] Fix typo in comment (auxilliary -> auxiliary) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 07/24] Fix typo in comment (embeded -> embedded) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 08/24] Fix typo in comment (consistant -> consistent) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 09/24] Fix typo in comment (dieing -> dying) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 10/24] Fix typos in comments (imediately -> immediately) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 11/24] Fix typos in comments (existance -> existence) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 12/24] Fix typos in comments (interupt -> interrupt) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 13/24] Fix typos in comments (instanciation -> instantiation) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 14/24] Fix typos in comments (neccessary -> necessary) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 15/24] Fix typos in comments and code (occured -> occurred and related) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 16/24] Fix typo in comment (relevent -> relevant) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 17/24] Fix typo in comment (responsiblity -> responsibility) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 18/24] Fix typo in comment (truely -> truly) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 19/24] Fix typos in comment (threshhold -> threshold, mapp -> map) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 20/24] ac97: Remove unused local variables Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 21/24] Fix spelling in comments (intruction -> instruction) Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 22/24] linux-user: Replace deprecated function Stefan Hajnoczi
2011-05-08 16:05 ` [Qemu-devel] [PATCH 23/24] libcacard: add correct subdirectory dependencies Stefan Hajnoczi
2011-05-08 16:05 ` Stefan Hajnoczi [this message]
2011-05-12 12:57 ` [Qemu-devel] [PULL] Trivial patches for April 26 to May 8 2011 Paolo Bonzini
2011-05-12 13:34 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304870719-20885-25-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=hare@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).