From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Hans de Goede <hdegoede@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] usb-linux: Add missing break statement
Date: Mon, 9 May 2011 14:11:05 +0200 [thread overview]
Message-ID: <1304943065-12023-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1304943065-12023-1-git-send-email-kraxel@redhat.com>
From: Stefan Weil <weil@mail.berlios.de>
cppcheck report:
usb-linux.c:661: warning: Redundant assignment of "len" in switch
Please check whether adding a break statement
is the correct solution for this warning.
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
usb-linux.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/usb-linux.c b/usb-linux.c
index 36a01ea..0ef1d26 100644
--- a/usb-linux.c
+++ b/usb-linux.c
@@ -659,6 +659,7 @@ static int usb_host_handle_iso_data(USBHostDevice *s, USBPacket *p, int in)
switch(errno) {
case ETIMEDOUT:
len = USB_RET_NAK;
+ break;
case EPIPE:
default:
len = USB_RET_STALL;
--
1.7.1
next prev parent reply other threads:[~2011-05-09 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 12:11 [Qemu-devel] [PULL] usb: build fixes Gerd Hoffmann
2011-05-09 12:11 ` [Qemu-devel] [PATCH 1/2] usb-musb: uninline functions Gerd Hoffmann
2011-05-09 12:11 ` Gerd Hoffmann [this message]
2011-05-09 12:50 ` [Qemu-devel] [PULL] usb: build fixes Peter Maydell
2011-05-09 14:25 ` Gerd Hoffmann
2011-05-09 17:41 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304943065-12023-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).