From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJPJD-0005g5-Nj for qemu-devel@nongnu.org; Mon, 09 May 2011 08:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJPJC-000807-0G for qemu-devel@nongnu.org; Mon, 09 May 2011 08:11:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63255) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJPJB-0007zs-Pb for qemu-devel@nongnu.org; Mon, 09 May 2011 08:11:29 -0400 From: Gerd Hoffmann Date: Mon, 9 May 2011 14:11:05 +0200 Message-Id: <1304943065-12023-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1304943065-12023-1-git-send-email-kraxel@redhat.com> References: <1304943065-12023-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] usb-linux: Add missing break statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Hans de Goede From: Stefan Weil cppcheck report: usb-linux.c:661: warning: Redundant assignment of "len" in switch Please check whether adding a break statement is the correct solution for this warning. Cc: Hans de Goede Cc: Gerd Hoffmann Signed-off-by: Stefan Weil Signed-off-by: Gerd Hoffmann --- usb-linux.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 36a01ea..0ef1d26 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -659,6 +659,7 @@ static int usb_host_handle_iso_data(USBHostDevice *s, USBPacket *p, int in) switch(errno) { case ETIMEDOUT: len = USB_RET_NAK; + break; case EPIPE: default: len = USB_RET_STALL; -- 1.7.1