From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKSbh-0004Dp-NE for qemu-devel@nongnu.org; Thu, 12 May 2011 05:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKSbg-0000gn-JI for qemu-devel@nongnu.org; Thu, 12 May 2011 05:54:57 -0400 Received: from mtagate3.uk.ibm.com ([194.196.100.163]:37272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKSbg-0000gS-7n for qemu-devel@nongnu.org; Thu, 12 May 2011 05:54:56 -0400 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate3.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p4C9sscg030356 for ; Thu, 12 May 2011 09:54:54 GMT Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4C9snuA1990668 for ; Thu, 12 May 2011 10:54:54 +0100 Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4C9sn44020490 for ; Thu, 12 May 2011 03:54:49 -0600 From: Stefan Hajnoczi Date: Thu, 12 May 2011 10:54:42 +0100 Message-Id: <1305194086-9832-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v2 0/4] Coroutines for better asynchronous programming List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Paolo Bonzini , Venkateswararao Jujjuri QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes. Therefore many operations that could block are performed asynchronously and a callback is invoked when the operation has completed. This allows QEMU to continue executing while the operation is pending. The downside to callbacks is that they split up code into many smaller functions, each of which is a single step in a state machine that quickly becomes complex and hard to understand. Callback functions also result in lots of noise as variables are packed and unpacked into temporary structs that pass state to the callback function. This patch series introduces coroutines as a solution for writing asynchronous code while still having a nice sequential control flow. The semantics are explained in the first patch. The second patch adds automated tests. A nice feature of coroutines is that it is relatively easy to take synchronous code and lift it into a coroutine to make it asynchronous. Work has been done to move qcow2 request processing into coroutines and thereby make it asynchronous (today qcow2 will perform synchronous metadata accesses). This qcow2 work is still ongoing and not quite ready for mainline yet. Coroutines are also being used for virtfs (virtio-9p) so I have submitted this patch now because virtfs patches that depend on coroutines will follow shortly. Other areas of QEMU that could take advantage of coroutines include the VNC server, migration, and qemu-tools. v2: * Added ./check-coroutine --lifecycle-benchmark for performance measurement * Split pooling into a separate patch with performance justification * Set maximum pool size to prevent holding onto too many free coroutines * Added atexit(3) handler to free pool * Coding style cleanups Makefile | 3 +- Makefile.objs | 7 ++ check-coroutine.c | 238 ++++++++++++++++++++++++++++++++++++++++++++++++++ coroutine-ucontext.c | 73 +++++++++++++++ coroutine-win32.c | 57 ++++++++++++ qemu-coroutine-int.h | 55 ++++++++++++ qemu-coroutine.c | 168 +++++++++++++++++++++++++++++++++++ qemu-coroutine.h | 91 +++++++++++++++++++ trace-events | 5 + vl.c | 2 + 10 files changed, 698 insertions(+), 1 deletions(-)