From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKcxr-0001HY-G1 for qemu-devel@nongnu.org; Thu, 12 May 2011 16:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QKcxq-00020S-Da for qemu-devel@nongnu.org; Thu, 12 May 2011 16:58:31 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:48513) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QKcxq-00020K-41 for qemu-devel@nongnu.org; Thu, 12 May 2011 16:58:30 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p4CKfW3d022586 for ; Thu, 12 May 2011 14:41:32 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4CKwPM8153828 for ; Thu, 12 May 2011 14:58:25 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4CEvvmo001257 for ; Thu, 12 May 2011 08:57:57 -0600 From: "Venkateswararao Jujjuri (JV)" Date: Thu, 12 May 2011 13:57:47 -0700 Message-Id: <1305233867-4367-26-git-send-email-jvrao@linux.vnet.ibm.com> In-Reply-To: <1305233867-4367-1-git-send-email-jvrao@linux.vnet.ibm.com> References: <1305233867-4367-1-git-send-email-jvrao@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 25/25] [virtio-9p] coroutine and threading for remove/unlink List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, "Venkateswararao Jujjuri (JV)" , stefanha@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri " --- hw/9pfs/cofs.c | 28 ++++++++++++++++++++++++++++ hw/9pfs/virtio-9p-coth.h | 1 + hw/9pfs/virtio-9p.c | 11 ++--------- 3 files changed, 31 insertions(+), 9 deletions(-) diff --git a/hw/9pfs/cofs.c b/hw/9pfs/cofs.c index 06127f7..68cd3ab 100644 --- a/hw/9pfs/cofs.c +++ b/hw/9pfs/cofs.c @@ -269,3 +269,31 @@ int v9fs_co_mknod(V9fsState *s, V9fsString *path, uid_t uid, qemu_coroutine_yield(); return vs.err; } + +typedef struct V9fsThRemoveState { + V9fsState *s; + V9fsString *path; + int err; + V9fsRequest request; +} V9fsThRemoveState; + +static void v9fs_th_do_remove(V9fsRequest *request) +{ + V9fsThRemoveState *vsp = container_of(request, V9fsThRemoveState, request); + vsp->err = vsp->s->ops->remove(&vsp->s->ctx, vsp->path->data); + if (vsp->err < 0) { + vsp->err = -errno; + } +} + +int v9fs_co_remove(V9fsState *s, V9fsString *path) +{ + V9fsThRemoveState vs; + vs.s = s; + vs.path = path; + vs.request.func = v9fs_th_do_remove; + vs.request.coroutine = qemu_coroutine_self(); + v9fs_qemu_submit_request(&vs.request); + qemu_coroutine_yield(); + return vs.err; +} diff --git a/hw/9pfs/virtio-9p-coth.h b/hw/9pfs/virtio-9p-coth.h index 3edab4e..b6428ec 100644 --- a/hw/9pfs/virtio-9p-coth.h +++ b/hw/9pfs/virtio-9p-coth.h @@ -67,4 +67,5 @@ extern int v9fs_co_lgetxattr(V9fsState *, V9fsString *, extern int v9fs_co_mknod(V9fsState *, V9fsString *, uid_t, gid_t, dev_t, mode_t); extern int v9fs_co_mkdir(V9fsState *, char *, mode_t, uid_t, gid_t); +extern int v9fs_co_remove(V9fsState *, V9fsString *); #endif diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c index 114162c..479ad78 100644 --- a/hw/9pfs/virtio-9p.c +++ b/hw/9pfs/virtio-9p.c @@ -212,11 +212,6 @@ static int v9fs_do_utimensat(V9fsState *s, V9fsString *path, return s->ops->utimensat(&s->ctx, path->data, times); } -static int v9fs_do_remove(V9fsState *s, V9fsString *path) -{ - return s->ops->remove(&s->ctx, path->data); -} - static int v9fs_do_fsync(V9fsState *s, int fd, int datasync) { return s->ops->fsync(&s->ctx, fd, datasync); @@ -2627,10 +2622,8 @@ static void v9fs_remove(void *opaque) err = -EINVAL; goto out; } - err = v9fs_do_remove(copdu->s, &fidp->path); - if (err < 0) { - err = -errno; - } else { + err = v9fs_co_remove(copdu->s, &fidp->path); + if (!err) { err = offset; } -- 1.7.1