qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 01/21] scsi: add tracing of scsi requests
Date: Mon, 16 May 2011 14:16:17 +0200	[thread overview]
Message-ID: <1305548197-16196-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1305548197-16196-1-git-send-email-pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-bus.c |    6 ++++++
 trace-events  |    6 ++++++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index ceeb4ec..0fd85fc 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -4,6 +4,7 @@
 #include "scsi-defs.h"
 #include "qdev.h"
 #include "blockdev.h"
+#include "trace.h"
 
 static char *scsibus_get_fw_dev_path(DeviceState *dev);
 
@@ -141,6 +142,7 @@ SCSIRequest *scsi_req_alloc(size_t size, SCSIDevice *d, uint32_t tag, uint32_t l
     req->lun = lun;
     req->status = -1;
     req->enqueued = true;
+    trace_scsi_req_alloc(req->dev->id, req->lun, req->tag);
     QTAILQ_INSERT_TAIL(&d->requests, req, next);
     return req;
 }
@@ -159,6 +161,7 @@ SCSIRequest *scsi_req_find(SCSIDevice *d, uint32_t tag)
 
 static void scsi_req_dequeue(SCSIRequest *req)
 {
+    trace_scsi_req_dequeue(req->dev->id, req->lun, req->tag);
     if (req->enqueued) {
         QTAILQ_REMOVE(&req->dev->requests, req, next);
         req->enqueued = false;
@@ -195,6 +198,7 @@ static int scsi_req_length(SCSIRequest *req, uint8_t *cmd)
         req->cmd.len = 12;
         break;
     default:
+        trace_scsi_req_parse_bad(req->dev->id, req->lun, req->tag, cmd[0]);
         return -1;
     }
 
@@ -392,6 +396,8 @@ int scsi_req_parse(SCSIRequest *req, uint8_t *buf)
     memcpy(req->cmd.buf, buf, req->cmd.len);
     scsi_req_xfer_mode(req);
     req->cmd.lba = scsi_req_lba(req);
+    trace_scsi_req_parsed(req->dev->id, req->lun, req->tag, buf[0],
+                          req->cmd.mode, req->cmd.xfer, req->cmd.lba);
     return 0;
 }
 
diff --git a/trace-events b/trace-events
index a00b63c..55f89b4 100644
--- a/trace-events
+++ b/trace-events
@@ -205,6 +205,12 @@ disable usb_set_config(int addr, int config, int ret) "dev %d, config %d, ret %d
 disable usb_clear_device_feature(int addr, int feature, int ret) "dev %d, feature %d, ret %d"
 disable usb_set_device_feature(int addr, int feature, int ret) "dev %d, feature %d, ret %d"
 
+# hw/scsi-bus.c
+disable scsi_req_alloc(int target, int lun, int tag) "target %d lun %d tag %d"
+disable scsi_req_dequeue(int target, int lun, int tag) "target %d lun %d tag %d"
+disable scsi_req_parsed(int target, int lun, int tag, int cmd, int mode, int xfer, uint64_t lba) "target %d lun %d tag %d command %d dir %d length %d lba %"PRIu64""
+disable scsi_req_parse_bad(int target, int lun, int tag, int cmd) "target %d lun %d tag %d command %d"
+
 # vl.c
 disable vm_state_notify(int running, int reason) "running %d reason %d"
 
-- 
1.7.4.4

  reply	other threads:[~2011-05-16 12:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 12:16 [Qemu-devel] [PATCH v2 00/21] SCSI subsystem improvements Paolo Bonzini
2011-05-16 12:16 ` Paolo Bonzini [this message]
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 02/21] scsi-generic: Remove bogus double complete Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 03/21] scsi: introduce scsi_req_data Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 04/21] scsi: introduce SCSIBusOps Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 05/21] scsi: reference-count requests Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 06/21] lsi: extract lsi_find_by_tag Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 07/21] scsi: Use 'SCSIRequest' directly Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 08/21] scsi: commonize purging requests Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 09/21] scsi: introduce scsi_req_abort Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 10/21] scsi: introduce scsi_req_cancel Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 11/21] scsi: use scsi_req_complete Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 12/21] scsi: Update sense code handling Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 13/21] scsi: do not call send_command directly Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 14/21] scsi: introduce scsi_req_new Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 15/21] scsi: introduce scsi_req_kick Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 16/21] scsi: introduce scsi_req_get_buf Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 17/21] scsi: Implement 'get_sense' callback Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 18/21] scsi-disk: add data direction checking Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 19/21] scsi: make write_data return void Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 20/21] scsi-generic: Handle queue full Paolo Bonzini
2011-05-16 12:16 ` [Qemu-devel] [PATCH v2 21/21] scsi: split command_complete callback in two Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305548197-16196-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).