From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Brad Hards <bradh@frogmouth.net>
Subject: [Qemu-devel] [PATCH 03/18] usb: remove fallback to bNumInterfaces if no .nif
Date: Mon, 16 May 2011 21:56:07 +0200 [thread overview]
Message-ID: <1305575782-31766-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1305575782-31766-1-git-send-email-kraxel@redhat.com>
From: Brad Hards <bradh@frogmouth.net>
All callers have been updated.
Signed-off-by: Brad Hards <bradh@frogmouth.net>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb-desc.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb-desc.c b/hw/usb-desc.c
index 62591f2..a784155 100644
--- a/hw/usb-desc.c
+++ b/hw/usb-desc.c
@@ -76,7 +76,7 @@ int usb_desc_config(const USBDescConfig *conf, uint8_t *dest, size_t len)
{
uint8_t bLength = 0x09;
uint16_t wTotalLength = 0;
- int i, rc, count;
+ int i, rc;
if (len < bLength) {
return -1;
@@ -91,8 +91,7 @@ int usb_desc_config(const USBDescConfig *conf, uint8_t *dest, size_t len)
dest[0x08] = conf->bMaxPower;
wTotalLength += bLength;
- count = conf->nif ? conf->nif : conf->bNumInterfaces;
- for (i = 0; i < count; i++) {
+ for (i = 0; i < conf->nif; i++) {
rc = usb_desc_iface(conf->ifs + i, dest + wTotalLength, len - wTotalLength);
if (rc < 0) {
return rc;
--
1.7.1
next prev parent reply other threads:[~2011-05-16 19:56 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 19:56 [Qemu-devel] [PATCH 00/18] usb patch queue: add usb 2.0 Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 01/18] usb: Add Interface Association Descriptor descriptor type Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 02/18] usb: update config descriptors to identify number of interfaces Gerd Hoffmann
2011-05-16 19:56 ` Gerd Hoffmann [this message]
2011-05-16 19:56 ` [Qemu-devel] [PATCH 04/18] usb: add support for "grouped" interfaces and the Interface Association Descriptor Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 05/18] Bug #757654: UHCI fails to signal stall response patch Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 06/18] usb: Pass the packet to the device's handle_control callback Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 07/18] usb-linux: use usb_generic_handle_packet() Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 08/18] usb-linux: fix device path aka physical port handling Gerd Hoffmann
2011-05-17 16:38 ` Markus Armbruster
2011-05-16 19:56 ` [Qemu-devel] [PATCH 09/18] usb-linux: add hostport property Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 10/18] usb-linux: track aurbs in list Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 11/18] usb-linux: walk async urb list in cancel Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 12/18] usb-linux: split large xfers Gerd Hoffmann
2011-05-17 2:45 ` David Ahern
2011-05-17 7:10 ` Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 13/18] usb-linux: fix max_packet_size for highspeed Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 14/18] usb: add usb_handle_packet Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 15/18] usb: keep track of packet owner Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 16/18] usb: move cancel callback to USBDeviceInfo Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 17/18] usb-storage: don't call usb_packet_complete twice Gerd Hoffmann
2011-05-16 19:56 ` [Qemu-devel] [PATCH 18/18] usb: add ehci adapter Gerd Hoffmann
2011-05-17 2:47 ` David Ahern
2011-05-17 7:20 ` Gerd Hoffmann
2011-05-17 12:42 ` David Ahern
2011-05-17 13:46 ` Gerd Hoffmann
2011-05-17 14:19 ` David Ahern
2011-05-17 14:36 ` Gerd Hoffmann
2011-05-17 17:15 ` Erik Rull
2011-05-17 13:52 ` David Ahern
2011-05-17 15:02 ` Gerd Hoffmann
2011-05-17 17:05 ` David Ahern
2011-05-17 17:36 ` Hans de Goede
2011-05-17 17:43 ` [Qemu-devel] USB streaming [Re: [PATCH 18/18] usb: add ehci adapter] David Ahern
2011-05-17 18:44 ` Hans de Goede
2011-05-17 19:10 ` David Ahern
2011-05-17 19:18 ` David Ahern
2011-05-18 8:25 ` Hans de Goede
2011-05-17 17:33 ` [Qemu-devel] [PATCH 18/18] usb: add ehci adapter Hans de Goede
2011-05-17 17:00 ` David Ahern
2011-05-17 20:39 ` Blue Swirl
2011-05-17 20:51 ` David Ahern
2011-05-21 10:34 ` Andreas Färber
2011-05-16 20:04 ` [Qemu-devel] [PATCH 00/18] usb patch queue: add usb 2.0 Anthony Liguori
2011-05-17 7:36 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2011-05-23 9:43 [Qemu-devel] [PULL] usb patch queue: initial usb 2.0 support Gerd Hoffmann
2011-05-23 9:43 ` [Qemu-devel] [PATCH 03/18] usb: remove fallback to bNumInterfaces if no .nif Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305575782-31766-4-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=bradh@frogmouth.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).