qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
	"Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>,
	stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] [V3 22/24] [virtio-9p] Remove post functions for v9fs_remove
Date: Wed, 18 May 2011 19:57:12 -0700	[thread overview]
Message-ID: <1305773834-16359-23-git-send-email-jvrao@linux.vnet.ibm.com> (raw)
In-Reply-To: <1305773834-16359-1-git-send-email-jvrao@linux.vnet.ibm.com>

Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
---
 hw/9pfs/virtio-9p.c |   26 +++++++-------------------
 1 files changed, 7 insertions(+), 19 deletions(-)

diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 8dd6f7d..1e860c6 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -2580,22 +2580,6 @@ out:
     complete_pdu(s, pdu, err);
 }
 
-static void v9fs_remove_post_remove(V9fsState *s, V9fsRemoveState *vs,
-                                                                int err)
-{
-    if (err < 0) {
-        err = -errno;
-    } else {
-        err = vs->offset;
-    }
-
-    /* For TREMOVE we need to clunk the fid even on failed remove */
-    free_fid(s, vs->fidp->fid);
-
-    complete_pdu(s, vs->pdu, err);
-    qemu_free(vs);
-}
-
 static void v9fs_remove(void *opaque)
 {
     V9fsPDU *pdu = opaque;
@@ -2615,11 +2599,15 @@ static void v9fs_remove(void *opaque)
         err = -EINVAL;
         goto out;
     }
-
     err = v9fs_do_remove(s, &vs->fidp->path);
-    v9fs_remove_post_remove(s, vs, err);
-    return;
+    if (err < 0) {
+        err = -errno;
+    } else {
+        err = vs->offset;
+    }
 
+    /* For TREMOVE we need to clunk the fid even on failed remove */
+    free_fid(s, vs->fidp->fid);
 out:
     complete_pdu(s, pdu, err);
     qemu_free(vs);
-- 
1.7.1

  parent reply	other threads:[~2011-05-19  2:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19  2:56 [Qemu-devel] [V3 0/24] Async threading for VirtFS using glib threads & coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 01/24] [virtio-9p] Add infrastructure to support glib threads and coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 02/24] [virtio-9p] Change all pdu handlers to coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 03/24] [virtio-9p] Remove post functions for v9fs_readlink Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 04/24] [virtio-9p] clean up v9fs_readlink Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 05/24] [virtio-9p] coroutines for readlink Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 06/24] [virtio-9p] Remove post functions for v9fs_mkdir Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 07/24] [virtio-9p] clean up v9fs_mkdir Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 08/24] hw/9pfs: Add yield support for readdir related coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:56 ` [Qemu-devel] [V3 09/24] hw/9pfs: Update v9fs_readdir to use coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 10/24] hw/9pfs: Add yield support to statfs coroutine Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 11/24] hw/9pfs: Update v9fs_statfs to use coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 12/24] hw/9pfs: Add yield support to lstat coroutine Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 13/24] hw/9pfs: Update v9fs_getattr to use coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 14/24] hw/9pfs: Add yield support to setattr related coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 15/24] hw/9pfs: Update v9fs_setattr to use coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 16/24] hw/9pfs: Add yield support to xattr related coroutine Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 17/24] hw/9pfs: Update v9fs_xattrwalk to coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 18/24] hw/9pfs: Update v9fs_xattrcreate to use coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 19/24] hw/9pfs: Add yield support to mknod coroutine Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 20/24] hw/9pfs: Update v9fs_mknod to use coroutines Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 21/24] [virtio-9p] coroutine and threading for mkdir Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` Venkateswararao Jujjuri (JV) [this message]
2011-05-19  2:57 ` [Qemu-devel] [V3 23/24] [virtio-9p] clean up v9fs_remove Venkateswararao Jujjuri (JV)
2011-05-19  2:57 ` [Qemu-devel] [V3 24/24] [virtio-9p] coroutine and threading for remove/unlink Venkateswararao Jujjuri (JV)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305773834-16359-23-git-send-email-jvrao@linux.vnet.ibm.com \
    --to=jvrao@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).