From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: amit.shah@redhat.com, alevy@redhat.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output
Date: Thu, 19 May 2011 13:37:15 +0200 [thread overview]
Message-ID: <1305805037-17752-3-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1305805037-17752-1-git-send-email-armbru@redhat.com>
Old version looks like this in info qtree (last four lines):
dev: virtconsole, id ""
dev-prop: is_console = 1
dev-prop: nr = 0
dev-prop: chardev = <null>
dev-prop: name = <null>
dev-prop-int: id: 0
dev-prop-int: guest_connected: 1
dev-prop-int: host_connected: 0
dev-prop-int: throttled: 0
Indentation is off, and "dev-prop-int" suggests these are properties
you can configure with -device, which isn't the case. The other
buses' print_dev() callbacks don't do that. For instance, PCI's
output looks like this:
class Ethernet controller, addr 00:03.0, pci id 1af4:1000 (sub 1af4:0001)
bar 0: i/o at 0xffffffffffffffff [0x1e]
bar 1: mem at 0xffffffffffffffff [0xffe]
bar 6: mem at 0xffffffffffffffff [0xfffe]
Change virtser_bus_dev_print() to that style. Result:
dev: virtconsole, id ""
dev-prop: is_console = 1
dev-prop: nr = 0
dev-prop: chardev = <null>
dev-prop: name = <null>
port 0, guest on, host off, throttle off
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/virtio-serial-bus.c | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index f10d48f..bd3121e 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -658,14 +658,11 @@ static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
{
VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
- monitor_printf(mon, "%*s dev-prop-int: id: %u\n",
- indent, "", port->id);
- monitor_printf(mon, "%*s dev-prop-int: guest_connected: %d\n",
- indent, "", port->guest_connected);
- monitor_printf(mon, "%*s dev-prop-int: host_connected: %d\n",
- indent, "", port->host_connected);
- monitor_printf(mon, "%*s dev-prop-int: throttled: %d\n",
- indent, "", port->throttled);
+ monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
+ indent, "", port->id,
+ port->guest_connected ? "on" : "off",
+ port->host_connected ? "on" : "off",
+ port->throttled ? "on" : "off");
}
/* This function is only used if a port id is not provided by the user */
--
1.7.2.3
next prev parent reply other threads:[~2011-05-19 11:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 11:37 [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 1/4] usb-ccid: Drop unused CCIDCardInfo callback print() Markus Armbruster
2011-05-19 11:49 ` Alon Levy
2011-05-19 11:37 ` Markus Armbruster [this message]
2011-05-19 13:10 ` [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output Amit Shah
2011-05-19 14:18 ` Markus Armbruster
2011-05-19 14:24 ` Amit Shah
2011-06-27 19:32 ` Andreas Färber
2011-06-29 8:33 ` Gerd Hoffmann
2011-06-29 9:26 ` Markus Armbruster
2011-06-29 18:33 ` Andreas Färber
2011-06-29 9:22 ` Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props Markus Armbruster
2011-05-19 13:11 ` Amit Shah
2011-05-19 14:05 ` Markus Armbruster
2011-05-19 14:08 ` Amit Shah
2011-05-19 11:37 ` [Qemu-devel] [PATCH 4/4] ide: Turn properties any IDE device must have into bus properties Markus Armbruster
2011-05-19 12:11 ` [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Gerd Hoffmann
2011-06-24 11:57 ` Markus Armbruster
2011-06-27 9:54 ` Amit Shah
2011-06-27 12:36 ` Markus Armbruster
2011-06-28 11:26 ` Amit Shah
2011-06-28 12:24 ` Markus Armbruster
2011-06-28 12:34 ` Amit Shah
2011-07-23 16:54 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305805037-17752-3-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=alevy@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).