qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH]  #include cleanliness
Date: Thu, 19 May 2011 10:17:42 -0400	[thread overview]
Message-ID: <1305814662-16184-1-git-send-email-avi@redhat.com> (raw)

My mother always told me to explicitly #include any headers need to compile
a file, instead of relying on other #includes to bring them in.  This patch
fixes up targphys.h and cpu-common.h in this regard.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 cpu-common.h |    4 ++++
 targphys.h   |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/cpu-common.h b/cpu-common.h
index 151c32c..2009adc 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -18,6 +18,10 @@
 #include "bswap.h"
 #include "qemu-queue.h"
 
+#include "qemu-common.h"
+
+#include <stdbool.h>
+
 #if !defined(CONFIG_USER_ONLY)
 
 enum device_endian {
diff --git a/targphys.h b/targphys.h
index 95648d6..501add2 100644
--- a/targphys.h
+++ b/targphys.h
@@ -3,6 +3,8 @@
 #ifndef TARGPHYS_H
 #define TARGPHYS_H
 
+#include <stdint.h>
+
 #ifdef TARGET_PHYS_ADDR_BITS
 /* target_phys_addr_t is the type of a physical address (its size can
    be different from 'target_ulong').  */
-- 
1.7.5.1

             reply	other threads:[~2011-05-19 14:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-19 14:17 Avi Kivity [this message]
2011-05-29 16:30 ` [Qemu-devel] [PATCH] #include cleanliness Avi Kivity
2011-05-29 22:06 ` Anthony Liguori
2011-05-30  9:06   ` Avi Kivity
2011-05-31 13:43     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305814662-16184-1-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).