From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN42z-0001ei-Dk for qemu-devel@nongnu.org; Thu, 19 May 2011 10:17:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QN42u-00067K-L7 for qemu-devel@nongnu.org; Thu, 19 May 2011 10:17:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN42u-00067D-7J for qemu-devel@nongnu.org; Thu, 19 May 2011 10:17:48 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4JEHktk021763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 May 2011 10:17:47 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4JEHj6Q016376 for ; Thu, 19 May 2011 10:17:46 -0400 From: Avi Kivity Date: Thu, 19 May 2011 10:17:42 -0400 Message-Id: <1305814662-16184-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH] #include cleanliness List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org My mother always told me to explicitly #include any headers need to compile a file, instead of relying on other #includes to bring them in. This patch fixes up targphys.h and cpu-common.h in this regard. Signed-off-by: Avi Kivity --- cpu-common.h | 4 ++++ targphys.h | 2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index 151c32c..2009adc 100644 --- a/cpu-common.h +++ b/cpu-common.h @@ -18,6 +18,10 @@ #include "bswap.h" #include "qemu-queue.h" +#include "qemu-common.h" + +#include + #if !defined(CONFIG_USER_ONLY) enum device_endian { diff --git a/targphys.h b/targphys.h index 95648d6..501add2 100644 --- a/targphys.h +++ b/targphys.h @@ -3,6 +3,8 @@ #ifndef TARGPHYS_H #define TARGPHYS_H +#include + #ifdef TARGET_PHYS_ADDR_BITS /* target_phys_addr_t is the type of a physical address (its size can be different from 'target_ulong'). */ -- 1.7.5.1