From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, patches@linaro.org
Subject: [Qemu-devel] [PATCH 2/3] net: Don't warn about the default network setup
Date: Fri, 20 May 2011 16:50:00 +0100 [thread overview]
Message-ID: <1305906601-25324-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1305906601-25324-1-git-send-email-peter.maydell@linaro.org>
Don't warn about the default network setup that you get if no command line
-net options are specified. There are two cases that we would otherwise
complain about:
(1) board doesn't support a NIC but the implicit "-net nic" requested one
(2) CONFIG_SLIRP not set, so the implicit "-net nic" sets up a nic that
isn't connected to anything
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
net.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/net.c b/net.c
index 1b521a9..68c2840 100644
--- a/net.c
+++ b/net.c
@@ -1305,6 +1305,18 @@ void net_check_clients(void)
VLANState *vlan;
VLANClientState *vc;
+ /* Don't warn about the default network setup that you get if
+ * no command line -net or -netdev options are specified. There
+ * are two cases that we would otherwise complain about:
+ * (1) board doesn't support a NIC but the implicit "-net nic"
+ * requested one
+ * (2) CONFIG_SLIRP not set, in which case the implicit "-net nic"
+ * sets up a nic that isn't connected to anything.
+ */
+ if (default_net) {
+ return;
+ }
+
QTAILQ_FOREACH(vlan, &vlans, next) {
int has_nic = 0, has_host_dev = 0;
--
1.7.1
next prev parent reply other threads:[~2011-05-20 15:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 15:49 [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix Peter Maydell
2011-05-20 15:49 ` [Qemu-devel] [PATCH 1/3] Revert "net: Improve the warnings for dubious command line option combinations" Peter Maydell
2011-05-20 15:50 ` Peter Maydell [this message]
2011-05-23 8:30 ` [Qemu-devel] [PATCH 2/3] net: Don't warn about the default network setup Markus Armbruster
2011-05-23 8:55 ` Peter Maydell
2011-05-20 15:50 ` [Qemu-devel] [PATCH 3/3] net: Warn about "-net nic" options which were ignored Peter Maydell
2011-05-23 8:34 ` Markus Armbruster
2011-05-20 15:55 ` [Qemu-devel] [PATCH 0/3] net: reimplement -net nic diagnostic fix Jan Kiszka
2011-05-20 16:04 ` Peter Maydell
2011-05-20 16:07 ` Jan Kiszka
2011-05-20 16:12 ` Peter Maydell
2011-05-20 16:15 ` Jan Kiszka
2011-05-23 8:35 ` Markus Armbruster
2011-06-05 13:12 ` Peter Maydell
2011-06-22 11:39 ` Peter Maydell
2011-06-22 12:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305906601-25324-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).