* [Qemu-devel] [PATCH] ppc: Fix compilation for ppc64-softmmu
@ 2011-05-20 20:30 Stefan Weil
2011-05-21 8:31 ` Alexander Graf
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2011-05-20 20:30 UTC (permalink / raw)
To: QEMU Developers; +Cc: Alexander Graf
When QEMU was configured with --enable-debug-tcg,
compilation fails in spr_write_booke206_mmucsr0() and in
spr_write_booke_pid(). Similar changes are also needed
in conditional code which is normally unused.
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
target-ppc/translate_init.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index b511afa..fc50ae3 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -73,7 +73,7 @@ static void spr_read_generic (void *opaque, int gprn, int sprn)
gen_load_spr(cpu_gpr[gprn], sprn);
#ifdef PPC_DUMP_SPR_ACCESSES
{
- TCGv t0 = tcg_const_i32(sprn);
+ TCGv_i32 t0 = tcg_const_i32(sprn);
gen_helper_load_dump_spr(t0);
tcg_temp_free_i32(t0);
}
@@ -85,7 +85,7 @@ static void spr_write_generic (void *opaque, int sprn, int gprn)
gen_store_spr(sprn, cpu_gpr[gprn]);
#ifdef PPC_DUMP_SPR_ACCESSES
{
- TCGv t0 = tcg_const_i32(sprn);
+ TCGv_i32 t0 = tcg_const_i32(sprn);
gen_helper_store_dump_spr(t0);
tcg_temp_free_i32(t0);
}
@@ -1367,16 +1367,16 @@ static void spr_write_e500_l1csr0 (void *opaque, int sprn, int gprn)
static void spr_write_booke206_mmucsr0 (void *opaque, int sprn, int gprn)
{
- TCGv t0 = tcg_const_i32(sprn);
+ TCGv_i32 t0 = tcg_const_i32(sprn);
gen_helper_booke206_tlbflush(t0);
- tcg_temp_free(t0);
+ tcg_temp_free_i32(t0);
}
static void spr_write_booke_pid (void *opaque, int sprn, int gprn)
{
- TCGv t0 = tcg_const_i32(sprn);
+ TCGv_i32 t0 = tcg_const_i32(sprn);
gen_helper_booke_setpid(t0, cpu_gpr[gprn]);
- tcg_temp_free(t0);
+ tcg_temp_free_i32(t0);
}
#endif
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ppc: Fix compilation for ppc64-softmmu
2011-05-20 20:30 [Qemu-devel] [PATCH] ppc: Fix compilation for ppc64-softmmu Stefan Weil
@ 2011-05-21 8:31 ` Alexander Graf
2011-05-26 18:38 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Graf @ 2011-05-21 8:31 UTC (permalink / raw)
To: Stefan Weil; +Cc: Stefan Hajnoczi, QEMU Developers
On 20.05.2011, at 22:30, Stefan Weil wrote:
> When QEMU was configured with --enable-debug-tcg,
> compilation fails in spr_write_booke206_mmucsr0() and in
> spr_write_booke_pid(). Similar changes are also needed
> in conditional code which is normally unused.
Stefan (Hajnoczi), can we add --enable-debug-tcg builds to the buildbot runs? I'd like to catch these without Stefan (Weil) being around as well - and preferably on my staging tree and not on upstream :(.
Thanks for the patch, applied to ppc-next.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ppc: Fix compilation for ppc64-softmmu
2011-05-21 8:31 ` Alexander Graf
@ 2011-05-26 18:38 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2011-05-26 18:38 UTC (permalink / raw)
To: Alexander Graf; +Cc: QEMU Developers, Stefan Hajnoczi
On 21 May 2011 09:31, Alexander Graf <agraf@suse.de> wrote:
> On 20.05.2011, at 22:30, Stefan Weil wrote:
>> When QEMU was configured with --enable-debug-tcg,
>> compilation fails in spr_write_booke206_mmucsr0() and in
>> spr_write_booke_pid(). Similar changes are also needed
>> in conditional code which is normally unused.
>
> Stefan (Hajnoczi), can we add --enable-debug-tcg builds
> to the buildbot runs?
--enable-debug implies --enable-debug-tcg, so I would think
that just running both with and without --enable-debug would
be sufficient.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-26 18:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-20 20:30 [Qemu-devel] [PATCH] ppc: Fix compilation for ppc64-softmmu Stefan Weil
2011-05-21 8:31 ` Alexander Graf
2011-05-26 18:38 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).