From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: TeLeMan <geleman@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 1/4] piix_pci: fix piix3_set_irq_pic()
Date: Sun, 22 May 2011 23:01:14 +0100 [thread overview]
Message-ID: <1306101677-26631-2-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1306101677-26631-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: TeLeMan <geleman@gmail.com>
If pic_irq is greater than 7, the irq level is always 0 on 32bits.
Signed-off-by: TeLeMan <geleman@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
hw/piix_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 7f1c4cc..85a320e 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -312,7 +312,7 @@ static void piix3_set_irq_pic(PIIX3State *piix3, int pic_irq)
{
qemu_set_irq(piix3->pic[pic_irq],
!!(piix3->pic_levels &
- (((1UL << PIIX_NUM_PIRQS) - 1) <<
+ (((1ULL << PIIX_NUM_PIRQS) - 1) <<
(pic_irq * PIIX_NUM_PIRQS))));
}
--
1.7.4.4
next prev parent reply other threads:[~2011-05-22 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-22 22:01 [Qemu-devel] [PULL 0/4] Trivial patches for May 16 to May 20 Stefan Hajnoczi
2011-05-22 22:01 ` Stefan Hajnoczi [this message]
2011-05-22 22:01 ` [Qemu-devel] [PATCH 2/4] hw/realview.c: Remove duplicate #include line Stefan Hajnoczi
2011-05-22 22:01 ` [Qemu-devel] [PATCH 3/4] hw/sd.c: Don't complain about SDIO commands CMD52/CMD53 Stefan Hajnoczi
2011-05-22 22:01 ` [Qemu-devel] [PATCH 4/4] Fix typos in comments (chek -> check) Stefan Hajnoczi
2011-05-23 21:35 ` [Qemu-devel] [PULL 0/4] Trivial patches for May 16 to May 20 Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306101677-26631-2-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).