From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOGiM-0006HZ-PX for qemu-devel@nongnu.org; Sun, 22 May 2011 18:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QOGiL-0006j1-Of for qemu-devel@nongnu.org; Sun, 22 May 2011 18:01:34 -0400 Received: from mtagate4.uk.ibm.com ([194.196.100.164]:47050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QOGiL-0006ir-Hk for qemu-devel@nongnu.org; Sun, 22 May 2011 18:01:33 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p4MM1U3n011139 for ; Sun, 22 May 2011 22:01:30 GMT Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4MM1PIw2441428 for ; Sun, 22 May 2011 23:01:30 +0100 Received: from d06av05.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4MM1OHO011907 for ; Sun, 22 May 2011 16:01:25 -0600 From: Stefan Hajnoczi Date: Sun, 22 May 2011 23:01:14 +0100 Message-Id: <1306101677-26631-2-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1306101677-26631-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1306101677-26631-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 1/4] piix_pci: fix piix3_set_irq_pic() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: TeLeMan , Anthony Liguori , Stefan Hajnoczi From: TeLeMan If pic_irq is greater than 7, the irq level is always 0 on 32bits. Signed-off-by: TeLeMan Signed-off-by: Stefan Hajnoczi --- hw/piix_pci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 7f1c4cc..85a320e 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -312,7 +312,7 @@ static void piix3_set_irq_pic(PIIX3State *piix3, int pic_irq) { qemu_set_irq(piix3->pic[pic_irq], !!(piix3->pic_levels & - (((1UL << PIIX_NUM_PIRQS) - 1) << + (((1ULL << PIIX_NUM_PIRQS) - 1) << (pic_irq * PIIX_NUM_PIRQS)))); } -- 1.7.4.4