From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQ0S4-0002Fv-6l for qemu-devel@nongnu.org; Fri, 27 May 2011 13:03:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQ0S1-0000MP-Iw for qemu-devel@nongnu.org; Fri, 27 May 2011 13:03:56 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:51502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQ0S1-0000Ki-6P for qemu-devel@nongnu.org; Fri, 27 May 2011 13:03:53 -0400 From: Stefan Weil Date: Fri, 27 May 2011 19:03:25 +0200 Message-Id: <1306515816-5386-2-git-send-email-weil@mail.berlios.de> In-Reply-To: <1306355129-23447-1-git-send-email-weil@mail.berlios.de> References: <1306355129-23447-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH v2 01/12] target-s390x: Fix wrong argument in call of tcg_gen_shl_i64() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: QEMU Developers tcg_gen_shl_i64 needs a 3rd argument of type TCGv_i64. Set tmp4 so it can be used here. v2: Don't call tcg_const_i64() inside of the loop because it creates additional code. Signed-off-by: Stefan Weil --- target-s390x/translate.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-s390x/translate.c b/target-s390x/translate.c index 8e71df3..865a9df 100644 --- a/target-s390x/translate.c +++ b/target-s390x/translate.c @@ -2056,7 +2056,7 @@ do_mh: even for very long ones... */ tmp = get_address(s, 0, b2, d2); tmp3 = tcg_const_i64(stm_len); - tmp4 = tcg_const_i64(32); + tmp4 = tcg_const_i64(op == 0x26 ? 32 : 4); for (i = r1;; i = (i + 1) % 16) { switch (op) { case 0x4: @@ -2070,7 +2070,7 @@ do_mh: #else tmp2 = tcg_temp_new_i64(); tcg_gen_qemu_ld32u(tmp2, tmp, get_mem_index(s)); - tcg_gen_shl_i64(tmp2, tmp2, 4); + tcg_gen_shl_i64(tmp2, tmp2, tmp4); tcg_gen_ext32u_i64(regs[i], regs[i]); tcg_gen_or_i64(regs[i], regs[i], tmp2); #endif -- 1.7.2.5