From: Hans de Goede <hdegoede@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>
Subject: [Qemu-devel] [PATCH 2/4] usb-bus: Don't allow speed mismatch while attaching devices
Date: Tue, 31 May 2011 11:39:41 +0200 [thread overview]
Message-ID: <1306834783-13070-3-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1306834783-13070-1-git-send-email-hdegoede@redhat.com>
---
hw/usb-bus.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index 2ae2678..1817d5c 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -200,6 +200,11 @@ static int do_attach(USBDevice *dev)
} else {
port = QTAILQ_FIRST(&bus->free);
}
+ if (!(port->speedmask & dev->speedmask)) {
+ fprintf(stderr, "Warning: speed mismatch trying to attach usb device %s to bus %s\n",
+ dev->product_desc, bus->qbus.name);
+ return -1;
+ }
dev->attached++;
QTAILQ_REMOVE(&bus->free, port, next);
--
1.7.5.1
next prev parent reply other threads:[~2011-05-31 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 9:39 [Qemu-devel] USB: automatically choose bus to connect to based on speed Hans de Goede
2011-05-31 9:39 ` [Qemu-devel] [PATCH 1/4] usb: Add a speedmask to devices Hans de Goede
2011-05-31 9:39 ` Hans de Goede [this message]
2011-05-31 9:39 ` [Qemu-devel] [PATCH 3/4] usb-bus: Automatically select right usb bus based on device and bus speed Hans de Goede
2011-05-31 9:39 ` [Qemu-devel] [PATCH 4/4] usb-linux: allow "compatible" high speed devices to connect at fullspeed Hans de Goede
2011-05-31 9:52 ` [Qemu-devel] USB: automatically choose bus to connect to based on speed Paolo Bonzini
2011-05-31 10:10 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306834783-13070-3-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).