From: "Cédric VINCENT" <cedric.vincent@st.com>
To: qemu-devel@nongnu.org
Cc: "Laurent ALFONSI" <laurent.alfonsi@st.com>,
"Cédric VINCENT" <cedric.vincent@st.com>,
"Riku Voipio" <riku.voipio@iki.fi>
Subject: [Qemu-devel] [PATCH] linux-user: Define AT_RANDOM to support target dynamic linkers that do ASLR
Date: Wed, 1 Jun 2011 13:42:31 +0200 [thread overview]
Message-ID: <1306928551-31723-1-git-send-email-cedric.vincent@st.com> (raw)
From: Laurent ALFONSI <laurent.alfonsi@st.com>
The dynamic linker of the GNU C library v2.10+ uses the ELF auxialiary
vector AT_RANDOM as a pointer to a 16-bit random value. Prior this
patch the value of AT_RANDOM was not defined by the ELF loader of QEMU
so the GNU dynamic linker de-referenced the NULL pointer instead. As
a consequence any target program linked to the GNU C library v2.10+
crashed due to a SEGFAULT.
Note AT_RANDOM now points to the start of the text segment thus the
16-bit value is not random at all, however it is definitively
readable. This "dummy" behavior could be improved later.
Signed-off-by: Laurent ALFONSI <laurent.alfonsi@st.com>
Signed-off-by: Cédric VINCENT <cedric.vincent@st.com>
---
You can easily test this patch with ARMedSlack-13+:
ftp://ftp.armedslack.org/armedslack/armedslack-devtools/minirootfs/roots/
linux-user/elfload.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index dcfeb7a..6f67286 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -927,7 +927,7 @@ struct exec
#define TARGET_ELF_PAGESTART(_v) ((_v) & ~(unsigned long)(TARGET_ELF_EXEC_PAGESIZE-1))
#define TARGET_ELF_PAGEOFFSET(_v) ((_v) & (TARGET_ELF_EXEC_PAGESIZE-1))
-#define DLINFO_ITEMS 12
+#define DLINFO_ITEMS 13
static inline void memcpy_fromfs(void * to, const void * from, unsigned long n)
{
@@ -1271,6 +1271,13 @@ static abi_ulong create_elf_tables(abi_ulong p, int argc, int envc,
NEW_AUX_ENT(AT_EGID, (abi_ulong) getegid());
NEW_AUX_ENT(AT_HWCAP, (abi_ulong) ELF_HWCAP);
NEW_AUX_ENT(AT_CLKTCK, (abi_ulong) sysconf(_SC_CLK_TCK));
+
+ /* The dynamic linker of the GNU C library v2.10+ uses the ELF
+ * auxialiary vector AT_RANDOM as a pointer to a 16-bit random
+ * value. Note the start of the text segment is not random at
+ * all, however it is definitively readeable. */
+ NEW_AUX_ENT(AT_RANDOM, (abi_ulong) info->start_code);
+
if (k_platform)
NEW_AUX_ENT(AT_PLATFORM, u_platform);
#ifdef ARCH_DLINFO
--
1.7.5.1
next reply other threads:[~2011-06-01 11:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 11:42 Cédric VINCENT [this message]
2011-06-01 13:26 ` [Qemu-devel] [PATCH] linux-user: Define AT_RANDOM to support target dynamic linkers that do ASLR Richard Henderson
2011-06-01 13:47 ` cedric.vincent
2011-06-01 14:35 ` [Qemu-devel] [PATCH v2] " Cédric VINCENT
2011-06-01 15:33 ` [Qemu-devel] [PATCH] " Richard Henderson
2011-06-03 6:46 ` cedric.vincent
2011-06-13 12:03 ` Laurent Alfonsi
2011-06-13 15:53 ` Richard Henderson
2011-06-20 6:43 ` [Qemu-devel] [PATCH v3] linux-user: Define AT_RANDOM to support target stack protection mechanism Cédric VINCENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306928551-31723-1-git-send-email-cedric.vincent@st.com \
--to=cedric.vincent@st.com \
--cc=laurent.alfonsi@st.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).