qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Fergeau <cfergeau@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 0/3] Fix unused-but-set-variable warnings
Date: Wed,  1 Jun 2011 14:56:29 +0200	[thread overview]
Message-ID: <1306932992-30075-1-git-send-email-cfergeau@redhat.com> (raw)

Hi,

Here are a few more "unused-but-set-variable" warning fixes which I got
when rebuilding qemu. I can fold the other 2 patches that were already
sent to this list in this series if needed.

The 3rd hunk of the ehci patch needs a review from someone who knows the
code, different values are assigned to the "pid" variable which the patch
deletes, and further down in the function, ehci->pid is used, so maybe
an "ehci->pid = pid;" line is missing in this function, in which case the
patch would hide a bug instead of solving it.

Similarly, the variable removed from the linux-user patch is assigned
different values depending on some conditions, maybe it's not right to
remove it but it should be used for "something".

Christophe


Christophe Fergeau (3):
  lsi: Fix unused-but-set-variable warning
  ehci: Fix unused-but-set-variable warning
  linux-user: Fix unused-but-set-variable warning

 hw/lsi53c895a.c        |    2 --
 hw/usb-ehci.c          |   11 +----------
 linux-user/linuxload.c |    9 +--------
 3 files changed, 2 insertions(+), 20 deletions(-)

-- 
1.7.5.2

             reply	other threads:[~2011-06-01 12:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 12:56 Christophe Fergeau [this message]
2011-06-01 12:56 ` [Qemu-devel] [PATCH 1/3] lsi: Fix unused-but-set-variable warning Christophe Fergeau
2011-06-01 14:19   ` Paolo Bonzini
2011-06-10 16:36     ` Peter Maydell
2011-06-10 19:21       ` Richard Henderson
2011-06-10 18:45   ` Stefan Hajnoczi
2011-06-01 12:56 ` [Qemu-devel] [PATCH 2/3] ehci: " Christophe Fergeau
2011-06-01 15:53   ` David Ahern
2011-06-01 16:21     ` Christophe Fergeau
2011-06-01 12:56 ` [Qemu-devel] [PATCH 3/3] linux-user: " Christophe Fergeau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306932992-30075-1-git-send-email-cfergeau@redhat.com \
    --to=cfergeau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).