From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRkyV-0000Xx-T2 for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:56:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRkyU-0000aV-4c for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:56:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRkyT-0000a6-AW for qemu-devel@nongnu.org; Wed, 01 Jun 2011 08:56:37 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p51CuZ9M031786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 1 Jun 2011 08:56:35 -0400 Received: from localhost.localdomain (ovpn-113-86.phx2.redhat.com [10.3.113.86]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p51CuXXF031284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 1 Jun 2011 08:56:34 -0400 From: Christophe Fergeau Date: Wed, 1 Jun 2011 14:56:29 +0200 Message-Id: <1306932992-30075-1-git-send-email-cfergeau@redhat.com> Subject: [Qemu-devel] [PATCH 0/3] Fix unused-but-set-variable warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, Here are a few more "unused-but-set-variable" warning fixes which I got when rebuilding qemu. I can fold the other 2 patches that were already sent to this list in this series if needed. The 3rd hunk of the ehci patch needs a review from someone who knows the code, different values are assigned to the "pid" variable which the patch deletes, and further down in the function, ehci->pid is used, so maybe an "ehci->pid = pid;" line is missing in this function, in which case the patch would hide a bug instead of solving it. Similarly, the variable removed from the linux-user patch is assigned different values depending on some conditions, maybe it's not right to remove it but it should be used for "something". Christophe Christophe Fergeau (3): lsi: Fix unused-but-set-variable warning ehci: Fix unused-but-set-variable warning linux-user: Fix unused-but-set-variable warning hw/lsi53c895a.c | 2 -- hw/usb-ehci.c | 11 +---------- linux-user/linuxload.c | 9 +-------- 3 files changed, 2 insertions(+), 20 deletions(-) -- 1.7.5.2