From: Brad Hards <bradh@frogmouth.net>
To: kraxel@redhat.com, qemu-devel@nongnu.org
Cc: Brad Hards <bradh@frogmouth.net>
Subject: [Qemu-devel] [PATCH 2/3] usb: Use defines for serial bus release number register for UHCI
Date: Thu, 2 Jun 2011 11:18:47 +1000 [thread overview]
Message-ID: <1306977528-20429-3-git-send-email-bradh@frogmouth.net> (raw)
In-Reply-To: <1306977528-20429-1-git-send-email-bradh@frogmouth.net>
Signed-off-by: Brad Hards <bradh@frogmouth.net>
---
hw/usb-uhci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index c0de05b..d9c86ad 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -1098,7 +1098,7 @@ static int usb_uhci_common_initfn(UHCIState *s)
pci_config_set_class(pci_conf, PCI_CLASS_SERIAL_USB);
/* TODO: reset value should be 0. */
pci_conf[PCI_INTERRUPT_PIN] = 4; // interrupt pin 3
- pci_conf[0x60] = 0x10; // release number
+ pci_conf[USB_SBRN] = USB_RELEASE_1; // release number
usb_bus_new(&s->bus, &s->dev.qdev);
for(i = 0; i < NB_PORTS; i++) {
--
1.7.4.1
next prev parent reply other threads:[~2011-06-02 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 1:18 [Qemu-devel] [0/3] usb: use defines instead of magic numbers for USB serial bus release number Brad Hards
2011-06-02 1:18 ` [Qemu-devel] [PATCH 1/3] usb: Add defines for USB Serial Bus Release Number register Brad Hards
2011-06-02 1:18 ` Brad Hards [this message]
2011-06-02 1:18 ` [Qemu-devel] [PATCH 3/3] usb: Use defines for serial bus release number register for EHCI Brad Hards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306977528-20429-3-git-send-email-bradh@frogmouth.net \
--to=bradh@frogmouth.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).