From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTZ6R-0008Kh-DR for qemu-devel@nongnu.org; Mon, 06 Jun 2011 08:40:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTZ6N-0005X7-EW for qemu-devel@nongnu.org; Mon, 06 Jun 2011 08:40:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTZ6M-0005WX-P0 for qemu-devel@nongnu.org; Mon, 06 Jun 2011 08:40:15 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p56CeDN9021326 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Jun 2011 08:40:13 -0400 From: Gerd Hoffmann Date: Mon, 6 Jun 2011 14:39:14 +0200 Message-Id: <1307363962-27223-24-git-send-email-kraxel@redhat.com> In-Reply-To: <1307363962-27223-1-git-send-email-kraxel@redhat.com> References: <1307363962-27223-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 23/31] usb-linux: Don't try to open the same device twice List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Gerd Hoffmann From: Hans de Goede If a user wants to redirect 2 identical usb sticks, in theory this is possible by doing: usb_add host:1234:5678 usb_add host:1234:5678 But this will lead to us trying to open the first stick twice, since we don't break the loop after having found a match in our filter list, so the next' filter list entry will result in us trying to open the same device again. Fix this by adding the missing break. Signed-off-by: Gerd Hoffmann --- usb-linux.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 82c1e7d..1208a97 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -1672,6 +1672,7 @@ static int usb_host_auto_scan(void *opaque, int bus_num, int addr, char *port, DPRINTF("husb: auto open: bus_num %d addr %d\n", bus_num, addr); usb_host_open(s, bus_num, addr, port, product_name, speed); + break; } return 0; -- 1.7.1