From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 3/6] slirp: fix guestfwd id
Date: Wed, 8 Jun 2011 09:24:45 +0100 [thread overview]
Message-ID: <1307521488-6066-4-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1307521488-6066-1-git-send-email-stefanha@linux.vnet.ibm.com>
From: Alexander Graf <agraf@suse.de>
When using -net user,guestfwd=... Qemu immediately complains about the id
being in invalid format. This is because we pass in an id that contains a
colon, while the id restrictions don't allow colons.
This patch changes the colon into a dot, making guestfwd work again.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
net/slirp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index e387a11..e057a14 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -614,7 +614,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str,
}
fwd = qemu_malloc(sizeof(struct GuestFwd));
- snprintf(buf, sizeof(buf), "guestfwd.tcp:%d", port);
+ snprintf(buf, sizeof(buf), "guestfwd.tcp.%d", port);
fwd->hd = qemu_chr_open(buf, p, NULL);
if (!fwd->hd) {
error_report("could not open guest forwarding device '%s'", buf);
--
1.7.4.4
next prev parent reply other threads:[~2011-06-08 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 8:24 [Qemu-devel] [PULL 0/6] Trivial patches for May 30 to June 8 2011 Stefan Hajnoczi
2011-06-08 8:24 ` [Qemu-devel] [PATCH 1/6] Fix compilation warning due to missing header for sigaction Stefan Hajnoczi
2011-06-08 8:24 ` [Qemu-devel] [PATCH 2/6] Fix compilation warning due to missing header for sigaction (followup) Stefan Hajnoczi
2011-06-08 8:24 ` Stefan Hajnoczi [this message]
2011-06-08 8:24 ` [Qemu-devel] [PATCH 4/6] m68k: Replace gen_im32() by tcg_const_i32() Stefan Hajnoczi
2011-06-08 8:24 ` [Qemu-devel] [PATCH 5/6] target-i386: Make x86 mfence and lfence illegal without SSE2 Stefan Hajnoczi
2011-06-08 8:24 ` [Qemu-devel] [PATCH 6/6] virtio: Move virtio-pci to hw library Stefan Hajnoczi
2011-06-09 12:39 ` [Qemu-devel] [PULL 0/6] Trivial patches for May 30 to June 8 2011 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307521488-6066-4-git-send-email-stefanha@linux.vnet.ibm.com \
--to=stefanha@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).