From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Anthony Liguori" <aliguori@us.ibm.com>,
"Juha Riihimäki" <juha.riihimaki@nokia.com>,
"Paul Brook" <paul@codesourcery.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH RFC 2/3] sysbus: Allow sysbus MMIO passthrough
Date: Wed, 8 Jun 2011 12:33:32 +0100 [thread overview]
Message-ID: <1307532813-27175-3-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1307532813-27175-1-git-send-email-peter.maydell@linaro.org>
Add new function sysbus_pass_mmio() to allow a sysbus device to
delegate MMIO to another sysbus device. This allows a limited
form of composition for sysbus devices.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/sysbus.c | 26 ++++++++++++++++++++++++++
hw/sysbus.h | 3 +++
2 files changed, 29 insertions(+), 0 deletions(-)
diff --git a/hw/sysbus.c b/hw/sysbus.c
index 01ebe47..793b0c1 100644
--- a/hw/sysbus.c
+++ b/hw/sysbus.c
@@ -43,6 +43,10 @@ void sysbus_mmio_unmap(SysBusDevice *dev, int n)
{
assert(n >= 0 && n < dev->num_mmio);
+ if (dev->mmio[n].delegate) {
+ sysbus_mmio_unmap(dev->mmio[n].delegate, dev->mmio[n].delegate_mmio);
+ return;
+ }
if (dev->mmio[n].addr == (target_phys_addr_t)-1) {
/* region already unmapped */
return;
@@ -60,6 +64,11 @@ void sysbus_mmio_map(SysBusDevice *dev, int n, target_phys_addr_t addr)
{
assert(n >= 0 && n < dev->num_mmio);
+ if (dev->mmio[n].delegate) {
+ sysbus_mmio_map(dev->mmio[n].delegate, dev->mmio[n].delegate_mmio,
+ addr);
+ return;
+ }
if (dev->mmio[n].addr == addr) {
/* ??? region already mapped here. */
return;
@@ -83,6 +92,11 @@ void sysbus_mmio_resize(SysBusDevice *dev, int n, target_phys_addr_t newsize)
target_phys_addr_t addr;
assert(n >= 0 && n < dev->num_mmio);
+ if (dev->mmio[n].delegate) {
+ sysbus_mmio_resize(dev->mmio[n].delegate, dev->mmio[n].delegate_mmio,
+ newsize);
+ return;
+ }
if (newsize != dev->mmio[n].size) {
addr = dev->mmio[n].addr;
if (addr != (target_phys_addr_t)-1) {
@@ -127,6 +141,7 @@ void sysbus_init_mmio(SysBusDevice *dev, target_phys_addr_t size,
assert(dev->num_mmio < QDEV_MAX_MMIO);
n = dev->num_mmio++;
+ dev->mmio[n].delegate = 0;
dev->mmio[n].addr = -1;
dev->mmio[n].size = size;
dev->mmio[n].iofunc = iofunc;
@@ -139,11 +154,22 @@ void sysbus_init_mmio_cb(SysBusDevice *dev, target_phys_addr_t size,
assert(dev->num_mmio < QDEV_MAX_MMIO);
n = dev->num_mmio++;
+ dev->mmio[n].delegate = 0;
dev->mmio[n].addr = -1;
dev->mmio[n].size = size;
dev->mmio[n].cb = cb;
}
+void sysbus_pass_mmio(SysBusDevice *dev, SysBusDevice *target, int target_mmio)
+{
+ int n;
+
+ assert(dev->num_mmio < QDEV_MAX_MMIO);
+ n = dev->num_mmio++;
+ dev->mmio[n].delegate = target;
+ dev->mmio[n].delegate_mmio = target_mmio;
+}
+
void sysbus_init_ioports(SysBusDevice *dev, pio_addr_t ioport, pio_addr_t size)
{
pio_addr_t i;
diff --git a/hw/sysbus.h b/hw/sysbus.h
index 70e2488..789e4c5 100644
--- a/hw/sysbus.h
+++ b/hw/sysbus.h
@@ -19,6 +19,8 @@ struct SysBusDevice {
qemu_irq *irqp[QDEV_MAX_IRQ];
int num_mmio;
struct {
+ SysBusDevice *delegate;
+ int delegate_mmio;
target_phys_addr_t addr;
target_phys_addr_t size;
mmio_mapfunc cb;
@@ -46,6 +48,7 @@ void sysbus_init_mmio(SysBusDevice *dev, target_phys_addr_t size,
ram_addr_t iofunc);
void sysbus_init_mmio_cb(SysBusDevice *dev, target_phys_addr_t size,
mmio_mapfunc cb);
+void sysbus_pass_mmio(SysBusDevice *dev, SysBusDevice *target, int target_mmio);
void sysbus_init_irq(SysBusDevice *dev, qemu_irq *p);
void sysbus_pass_irq(SysBusDevice *dev, SysBusDevice *target);
void sysbus_init_ioports(SysBusDevice *dev, pio_addr_t ioport, pio_addr_t size);
--
1.7.1
next prev parent reply other threads:[~2011-06-08 11:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 11:33 [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices Peter Maydell
2011-06-08 11:33 ` [Qemu-devel] [PATCH RFC 1/3] sysbus: Add support for resizing and unmapping MMIOs Peter Maydell
2011-06-08 11:33 ` Peter Maydell [this message]
2011-06-08 11:33 ` [Qemu-devel] [PATCH RFC 3/3] sysbus: Allow passthrough of single IRQ Peter Maydell
2011-06-08 12:29 ` [Qemu-devel] [PATCH RFC 0/3] basic support for composing sysbus devices Jan Kiszka
2011-06-09 16:40 ` Markus Armbruster
2011-06-09 17:03 ` Jan Kiszka
2011-06-10 8:13 ` Markus Armbruster
2011-06-10 12:51 ` Anthony Liguori
2011-06-10 13:10 ` Peter Maydell
2011-06-10 13:43 ` Jan Kiszka
2011-06-10 13:50 ` Peter Maydell
2011-06-10 14:22 ` Markus Armbruster
2011-06-10 14:45 ` Anthony Liguori
2011-06-10 14:34 ` Anthony Liguori
2011-06-10 14:12 ` Anthony Liguori
2011-06-10 14:18 ` Jan Kiszka
2011-06-10 14:31 ` Anthony Liguori
2011-06-10 14:07 ` Anthony Liguori
2011-06-10 14:59 ` Markus Armbruster
2011-06-10 15:43 ` Anthony Liguori
2011-06-12 17:12 ` Avi Kivity
2011-06-12 19:21 ` Anthony Liguori
2011-06-13 8:05 ` Avi Kivity
2011-06-13 17:53 ` Anthony Liguori
2011-06-13 20:59 ` Blue Swirl
2011-06-14 13:21 ` Anthony Liguori
2011-06-15 18:56 ` Blue Swirl
2011-06-15 20:00 ` Anthony Liguori
2011-06-15 20:20 ` Blue Swirl
2011-06-20 15:23 ` Paul Brook
2011-06-20 21:32 ` Blue Swirl
2011-06-21 8:16 ` Avi Kivity
2011-06-27 2:26 ` Paul Brook
2011-06-13 9:57 ` Gleb Natapov
2011-06-10 16:28 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307532813-27175-3-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=juha.riihimaki@nokia.com \
--cc=patches@linaro.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).