From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Josh Durgin <josh.durgin@dreamhost.com>,
Christian Brunner <chb@muc.de>
Subject: [Qemu-devel] [PATCH v2] block/rbd: Remove unused local variable
Date: Fri, 10 Jun 2011 22:05:30 +0200 [thread overview]
Message-ID: <1307736330-13457-1-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <BANLkTik4hCm4xDQStxAmn=iZ9GGE8Xx6ww@mail.gmail.com>
Variable 'snap' is assigned a value that is never used.
Remove snap and the related code.
v2:
The unused variable which was in function rbd_open is now in function
qemu_rbd_create, so the patch needed an update.
Cc: Christian Brunner <chb@muc.de>
Cc: Josh Durgin <josh.durgin@dreamhost.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
block/rbd.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index bdc448a..d5659cd 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -227,7 +227,6 @@ static int qemu_rbd_create(const char *filename, QEMUOptionParameter *options)
char name[RBD_MAX_IMAGE_NAME_SIZE];
char snap_buf[RBD_MAX_SNAP_NAME_SIZE];
char conf[RBD_MAX_CONF_SIZE];
- char *snap = NULL;
rados_t cluster;
rados_ioctx_t io_ctx;
int ret;
@@ -238,9 +237,6 @@ static int qemu_rbd_create(const char *filename, QEMUOptionParameter *options)
conf, sizeof(conf)) < 0) {
return -EINVAL;
}
- if (snap_buf[0] != '\0') {
- snap = snap_buf;
- }
/* Read out options */
while (options && options->name) {
--
1.7.2.5
next prev parent reply other threads:[~2011-06-10 20:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 20:15 [Qemu-devel] [PATCH] block/rbd: Remove unused local variable Stefan Weil
2011-05-22 12:07 ` Stefan Weil
2011-05-23 9:01 ` Christian Brunner
2011-05-23 10:13 ` Stefan Hajnoczi
2011-05-23 10:26 ` Kevin Wolf
2011-05-27 18:32 ` Stefan Weil
2011-05-27 20:46 ` Christian Brunner
2011-06-10 20:05 ` Stefan Weil [this message]
2011-06-13 18:06 ` [Qemu-devel] [PATCH v2] " Josh Durgin
2011-06-14 8:01 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307736330-13457-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=chb@muc.de \
--cc=josh.durgin@dreamhost.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).