From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWRjD-0003VB-Qs for qemu-devel@nongnu.org; Tue, 14 Jun 2011 07:24:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWRjC-0007AR-DC for qemu-devel@nongnu.org; Tue, 14 Jun 2011 07:24:15 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:35894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWRjB-00078u-So for qemu-devel@nongnu.org; Tue, 14 Jun 2011 07:24:14 -0400 From: Peter Maydell Date: Tue, 14 Jun 2011 12:24:04 +0100 Message-Id: <1308050644-4622-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] hw/usb-musb.c: Don't misuse usb_packet_complete() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , patches@linaro.org In musb_packet() handle final processing of non-asynchronous USB packets by directly calling musb_schedule_cb() rather than going through usb_packet_complete(). The latter will trigger an assertion because the packet doesn't belong to a device. Signed-off-by: Peter Maydell --- The fix here is as suggested by Gerd. hw/usb-musb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-musb.c b/hw/usb-musb.c index 6037193..3eed855 100644 --- a/hw/usb-musb.c +++ b/hw/usb-musb.c @@ -611,7 +611,7 @@ static void musb_packet(MUSBState *s, MUSBEndPoint *ep, } ep->status[dir] = ret; - usb_packet_complete(s->port.dev, &ep->packey[dir].p); + musb_schedule_cb(s->port.dev, &ep->packey[dir].p); } static void musb_tx_packet_complete(USBPacket *packey, void *opaque) -- 1.7.1