From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWXhB-0006m1-5j for qemu-devel@nongnu.org; Tue, 14 Jun 2011 13:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QWXhA-00083i-4K for qemu-devel@nongnu.org; Tue, 14 Jun 2011 13:46:32 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:37049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QWXh9-00083N-Lq for qemu-devel@nongnu.org; Tue, 14 Jun 2011 13:46:31 -0400 Received: by yxs7 with SMTP id 7so1386383yxs.4 for ; Tue, 14 Jun 2011 10:46:30 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Tue, 14 Jun 2011 10:44:52 -0700 Message-Id: <1308073492-24789-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH] vga: Fix type of map_addr/end. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: Jan Kiszka These addresses have been passed through pci_to_cpu_addr, and thus need to be full target_phys_addr_t. Signed-off-by: Richard Henderson Cc: Jan Kiszka --- hw/vga_int.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Jan's recent patch series reminded me that I found a related problem in my alpha-softmmu port this past weekend. Note that the slight re-ordering of the members avoids extra padding in the structure due to alignment. diff --git a/hw/vga_int.h b/hw/vga_int.h index d2811bd..b65775b 100644 --- a/hw/vga_int.h +++ b/hw/vga_int.h @@ -109,9 +109,9 @@ typedef struct VGACommonState { uint32_t vram_size; uint32_t lfb_addr; uint32_t lfb_end; - uint32_t map_addr; - uint32_t map_end; uint32_t lfb_vram_mapped; /* whether 0xa0000 is mapped as ram */ + target_phys_addr_t map_addr; + target_phys_addr_t map_end; uint32_t latch; uint8_t sr_index; uint8_t sr[256]; -- 1.7.5.2