qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Adam Litke <agl@us.ibm.com>
Subject: [Qemu-devel] [PATCH 01/13] qemu-config: }, { -> }, { to please checkpatch.pl
Date: Tue, 14 Jun 2011 19:18:19 +0100	[thread overview]
Message-ID: <1308075511-4745-2-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1308075511-4745-1-git-send-email-stefanha@linux.vnet.ibm.com>

The checkpatch.pl coding style checker complains that there should be a
space after the comma in },{.  Make it easy for others to change
qemu-config.c in the future by complying with the coding style here.

A follow-up patch adds new options to qemu-config.c and therefore
benefits from this fix.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 qemu-config.c |  160 ++++++++++++++++++++++++++++----------------------------
 1 files changed, 80 insertions(+), 80 deletions(-)

diff --git a/qemu-config.c b/qemu-config.c
index c63741c..7558fa8 100644
--- a/qemu-config.c
+++ b/qemu-config.c
@@ -12,70 +12,70 @@ static QemuOptsList qemu_drive_opts = {
             .name = "bus",
             .type = QEMU_OPT_NUMBER,
             .help = "bus number",
-        },{
+        }, {
             .name = "unit",
             .type = QEMU_OPT_NUMBER,
             .help = "unit number (i.e. lun for scsi)",
-        },{
+        }, {
             .name = "if",
             .type = QEMU_OPT_STRING,
             .help = "interface (ide, scsi, sd, mtd, floppy, pflash, virtio)",
-        },{
+        }, {
             .name = "index",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "cyls",
             .type = QEMU_OPT_NUMBER,
             .help = "number of cylinders (ide disk geometry)",
-        },{
+        }, {
             .name = "heads",
             .type = QEMU_OPT_NUMBER,
             .help = "number of heads (ide disk geometry)",
-        },{
+        }, {
             .name = "secs",
             .type = QEMU_OPT_NUMBER,
             .help = "number of sectors (ide disk geometry)",
-        },{
+        }, {
             .name = "trans",
             .type = QEMU_OPT_STRING,
             .help = "chs translation (auto, lba. none)",
-        },{
+        }, {
             .name = "media",
             .type = QEMU_OPT_STRING,
             .help = "media type (disk, cdrom)",
-        },{
+        }, {
             .name = "snapshot",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "file",
             .type = QEMU_OPT_STRING,
             .help = "disk image",
-        },{
+        }, {
             .name = "cache",
             .type = QEMU_OPT_STRING,
             .help = "host cache usage (none, writeback, writethrough, unsafe)",
-        },{
+        }, {
             .name = "aio",
             .type = QEMU_OPT_STRING,
             .help = "host AIO implementation (threads, native)",
-        },{
+        }, {
             .name = "format",
             .type = QEMU_OPT_STRING,
             .help = "disk format (raw, qcow2, ...)",
-        },{
+        }, {
             .name = "serial",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "rerror",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "werror",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "addr",
             .type = QEMU_OPT_STRING,
             .help = "pci address (virtio only)",
-        },{
+        }, {
             .name = "readonly",
             .type = QEMU_OPT_BOOL,
         },
@@ -91,64 +91,64 @@ static QemuOptsList qemu_chardev_opts = {
         {
             .name = "backend",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "path",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "host",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "port",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "localaddr",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "localport",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "to",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "ipv4",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "ipv6",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "wait",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "server",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "delay",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "telnet",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "width",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "height",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "cols",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "rows",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "mux",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "signal",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "name",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "debug",
             .type = QEMU_OPT_NUMBER,
         },
@@ -245,10 +245,10 @@ static QemuOptsList qemu_rtc_opts = {
         {
             .name = "base",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "clock",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "driftfix",
             .type = QEMU_OPT_STRING,
         },
@@ -263,10 +263,10 @@ static QemuOptsList qemu_global_opts = {
         {
             .name = "driver",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "property",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "value",
             .type = QEMU_OPT_STRING,
         },
@@ -282,13 +282,13 @@ static QemuOptsList qemu_mon_opts = {
         {
             .name = "mode",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "chardev",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "default",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "pretty",
             .type = QEMU_OPT_BOOL,
         },
@@ -318,40 +318,40 @@ static QemuOptsList qemu_cpudef_opts = {
         {
             .name = "name",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "level",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "vendor",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "family",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "model",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "stepping",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "feature_edx",      /* cpuid 0000_0001.edx */
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "feature_ecx",      /* cpuid 0000_0001.ecx */
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "extfeature_edx",   /* cpuid 8000_0001.edx */
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "extfeature_ecx",   /* cpuid 8000_0001.ecx */
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "xlevel",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "model_id",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "vendor_override",
             .type = QEMU_OPT_NUMBER,
         },
@@ -366,73 +366,73 @@ QemuOptsList qemu_spice_opts = {
         {
             .name = "port",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "tls-port",
             .type = QEMU_OPT_NUMBER,
-        },{
+        }, {
             .name = "addr",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "ipv4",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "ipv6",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "password",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "disable-ticketing",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "disable-copy-paste",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "sasl",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "x509-dir",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "x509-key-file",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "x509-key-password",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "x509-cert-file",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "x509-cacert-file",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "x509-dh-key-file",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "tls-ciphers",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "tls-channel",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "plaintext-channel",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "image-compression",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "jpeg-wan-compression",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "zlib-glz-wan-compression",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "streaming-video",
             .type = QEMU_OPT_STRING,
-        },{
+        }, {
             .name = "agent-mouse",
             .type = QEMU_OPT_BOOL,
-        },{
+        }, {
             .name = "playback-compression",
             .type = QEMU_OPT_BOOL,
         },
-- 
1.7.5.3

  reply	other threads:[~2011-06-14 18:19 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 18:18 [Qemu-devel] [PATCH 00/13] QED image streaming Stefan Hajnoczi
2011-06-14 18:18 ` Stefan Hajnoczi [this message]
2011-06-14 18:18 ` [Qemu-devel] [PATCH 02/13] block: add -drive copy-on-read=on|off Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 03/13] qed: replace is_write with flags field Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 04/13] qed: extract qed_start_allocating_write() Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 05/13] qed: make qed_aio_write_alloc() reusable Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 06/13] qed: add support for copy-on-read Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 07/13] qed: avoid deadlock on emulated synchronous I/O Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 08/13] qerror: add qerror_from_args() to create qerror objects Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 09/13] block: add bdrv_aio_copy_backing() Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 10/13] qmp: add QMP support for stream commands Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 11/13] block: add -drive stream=on|off Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 12/13] qed: intelligent streaming implementation Stefan Hajnoczi
2011-06-14 18:18 ` [Qemu-devel] [PATCH 13/13] trace: trace bdrv_aio_readv/writev error paths Stefan Hajnoczi
2011-06-15 10:46 ` [Qemu-devel] [PATCH 00/13] QED image streaming Philipp Hahn
2011-06-15 12:18   ` Stefan Hajnoczi
2011-06-16 12:35 ` [Qemu-devel] Image streaming and live block copy (was: [PATCH 00/13] QED image streaming) Kevin Wolf
2011-06-16 12:49   ` [Qemu-devel] Image streaming and live block copy Avi Kivity
2011-06-16 13:08     ` Kevin Wolf
2011-06-16 13:38       ` Avi Kivity
2011-06-16 14:52       ` Marcelo Tosatti
2011-06-16 15:30         ` Stefan Hajnoczi
2011-06-17 12:31           ` Marcelo Tosatti
2011-06-18  9:15             ` Stefan Hajnoczi
2011-06-18  9:17               ` Stefan Hajnoczi
2011-06-19 16:02                 ` Dor Laor
2011-06-24  9:28                   ` Stefan Hajnoczi
2011-06-26 12:50                     ` Dor Laor
2011-06-27  7:48                       ` Kevin Wolf
2011-06-27  9:13                         ` Dor Laor
2011-06-17 13:54           ` Marcelo Tosatti
2011-06-17  8:36         ` Kevin Wolf
2011-06-17  8:57           ` Stefan Hajnoczi
2011-06-17  9:22             ` Kevin Wolf
2011-06-17 10:11               ` Stefan Hajnoczi
2011-06-17 12:21           ` Anthony Liguori
2011-06-17 13:04           ` Marcelo Tosatti
2011-06-17 13:50           ` Marcelo Tosatti
2011-06-16 13:10   ` Anthony Liguori
2011-06-16 13:50     ` Kevin Wolf
2011-06-16 14:38   ` [Qemu-devel] Image streaming and live block copy (was: [PATCH 00/13] QED image streaming) Marcelo Tosatti
2011-06-16 14:55     ` Marcelo Tosatti
2011-06-17  8:21     ` [Qemu-devel] Image streaming and live block copy Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308075511-4745-2-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=agl@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).