qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>,
	Juan Quintela <quintela@redhat.com>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH 4/8] flatload: end_code was only used in a debug message
Date: Thu, 16 Jun 2011 17:37:11 +0100	[thread overview]
Message-ID: <1308242235-8261-5-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1308242235-8261-1-git-send-email-peter.maydell@linaro.org>

From: Juan Quintela <quintela@redhat.com>

Just unfold its definition in only use.

Signed-off-by: Juan Quintela <quintela@redhat.com>
[peter.maydell@linaro.org: fixed typo in the debug code,
added parentheses to fix precedence issue]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 linux-user/flatload.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index cd7af7c..6fb78f5 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -384,7 +384,7 @@ static int load_flat_file(struct linux_binprm * bprm,
     abi_ulong reloc = 0, rp;
     int i, rev, relocs = 0;
     abi_ulong fpos;
-    abi_ulong start_code, end_code;
+    abi_ulong start_code;
     abi_ulong indx_len;
 
     hdr = ((struct flat_hdr *) bprm->buf);		/* exec-header */
@@ -552,11 +552,10 @@ static int load_flat_file(struct linux_binprm * bprm,
 
     /* The main program needs a little extra setup in the task structure */
     start_code = textpos + sizeof (struct flat_hdr);
-    end_code = textpos + text_len;
 
     DBG_FLT("%s %s: TEXT=%x-%x DATA=%x-%x BSS=%x-%x\n",
             id ? "Lib" : "Load", bprm->filename,
-            (int) start_code, (int) end_code,
+            (int) start_code, (int) (textpos + text_len),
             (int) datapos,
             (int) (datapos + data_len),
             (int) (datapos + data_len),
-- 
1.7.1

  parent reply	other threads:[~2011-06-16 16:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16 16:37 [Qemu-devel] [PATCH 0/8] linux-user: Fix gcc 4.6 compile warnings Peter Maydell
2011-06-16 16:37 ` [Qemu-devel] [PATCH 1/8] linuxload: id_change was a write only variable Peter Maydell
2011-06-16 16:37 ` [Qemu-devel] [PATCH 2/8] syscall: really return ret code Peter Maydell
2011-06-16 16:37 ` [Qemu-devel] [PATCH 3/8] linux-user: syscall should use sanitized arg1 Peter Maydell
2011-06-16 16:37 ` Peter Maydell [this message]
2011-06-16 16:37 ` [Qemu-devel] [PATCH 5/8] flatload: memp was a write-only variable Peter Maydell
2011-06-16 16:37 ` [Qemu-devel] [PATCH 6/8] linux-user: Bump do_syscall() up to 8 syscall arguments Peter Maydell
2011-06-16 16:37 ` [Qemu-devel] [PATCH 7/8] linux-user/signal.c: Remove only-ever-set variable fpu_save_addr Peter Maydell
2011-06-16 16:37 ` [Qemu-devel] [PATCH 8/8] linux-user/signal.c: Remove unused fenab Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308242235-8261-5-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).