From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZ5Cr-0004LQ-Eu for qemu-devel@nongnu.org; Tue, 21 Jun 2011 13:57:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QZ5Cl-0000rc-IF for qemu-devel@nongnu.org; Tue, 21 Jun 2011 13:57:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QZ5Ck-0000rR-T5 for qemu-devel@nongnu.org; Tue, 21 Jun 2011 13:57:39 -0400 From: Luiz Capitulino Date: Tue, 21 Jun 2011 14:57:28 -0300 Message-Id: <1308679048-4441-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1308679048-4441-1-git-send-email-lcapitulino@redhat.com> References: <1308679048-4441-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] Reset system before loadvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: Jan Kiszka , qemu-devel@nongnu.org From: Jan Kiszka In case we load the vmstate during incoming migration, we start from a clean, default machine state as we went through system reset before. But if we load from a snapshot, the machine can be in any state. That can cause troubles if loading an older image which does not carry all state information the executing QEMU requires. Hardly any device takes care of this scenario. However, fixing this is trivial. We just need to issue a system reset during loadvm as well. Signed-off-by: Jan Kiszka Signed-off-by: Luiz Capitulino --- savevm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/savevm.c b/savevm.c index 939845c..8139bc7 100644 --- a/savevm.c +++ b/savevm.c @@ -2073,6 +2073,7 @@ int load_vmstate(const char *name) return -EINVAL; } + qemu_system_reset(VMRESET_SILENT); ret = qemu_loadvm_state(f); qemu_fclose(f); -- 1.7.6.rc2.11.g13b7