qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Fix compilation for non-POSIX system (w64)
@ 2011-06-23 19:19 Stefan Weil
  2011-06-24 10:24 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2011-06-23 19:19 UTC (permalink / raw)
  To: QEMU Developers; +Cc: qemu-trivial

compatfd.h is only needed with CONFIG_POSIX.
Compilation fails in compatfd.h for at least one non-POSIX systems (w64).

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 cpus.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/cpus.c b/cpus.c
index 0699f37..8501254 100644
--- a/cpus.c
+++ b/cpus.c
@@ -34,7 +34,9 @@
 
 #include "qemu-thread.h"
 #include "cpus.h"
+#ifdef CONFIG_POSIX
 #include "compatfd.h"
+#endif
 
 #ifdef SIGRTMIN
 #define SIG_IPI (SIGRTMIN+4)
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix compilation for non-POSIX system (w64)
  2011-06-23 19:19 [Qemu-devel] [PATCH] Fix compilation for non-POSIX system (w64) Stefan Weil
@ 2011-06-24 10:24 ` Stefan Hajnoczi
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-06-24 10:24 UTC (permalink / raw)
  To: Stefan Weil; +Cc: qemu-trivial, QEMU Developers

On Thu, Jun 23, 2011 at 09:19:53PM +0200, Stefan Weil wrote:
> compatfd.h is only needed with CONFIG_POSIX.
> Compilation fails in compatfd.h for at least one non-POSIX systems (w64).
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  cpus.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Thanks!  Jan's patch which is similar but uses #ifndef _WIN32 is already
queued.  The cpus.c qemu_signalfd() usage is #ifndef _WIN32, so I think
there's a logic to keeping that patch.

Stefan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-24 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-23 19:19 [Qemu-devel] [PATCH] Fix compilation for non-POSIX system (w64) Stefan Weil
2011-06-24 10:24 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).