From: famcool@gmail.com
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Fam Zheng <famcool@gmail.com>,
hch@lst.de, stefanha@gmail.com
Subject: [Qemu-devel] [PATCH v2 03/12] VMDK: probe for monolithicFlat images
Date: Fri, 24 Jun 2011 16:18:18 +0800 [thread overview]
Message-ID: <1308903507-10799-4-git-send-email-famcool@gmail.com> (raw)
In-Reply-To: <1308903507-10799-1-git-send-email-famcool@gmail.com>
From: Fam Zheng <famcool@gmail.com>
Probe as the same behavior as VMware does.
Recognize image as monolithicFlat descriptor file when the file is text
and the first effective line (not '#' leaded comment or space line) is
either 'version=1' or 'version=2'. No space or upper case charactors
accepted.
Signed-off-by: Fam Zheng <famcool@gmail.com>
---
block/vmdk.c | 37 ++++++++++++++++++++++++++++++++++---
1 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 0540ec5..71d81bc 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -102,10 +102,41 @@ static int vmdk_probe(const uint8_t *buf, int buf_size, const char *filename)
return 0;
magic = be32_to_cpu(*(uint32_t *)buf);
if (magic == VMDK3_MAGIC ||
- magic == VMDK4_MAGIC)
+ magic == VMDK4_MAGIC) {
return 100;
- else
- return 0;
+ } else {
+ const char *p = (const char *)buf;
+ const char *end = p + buf_size;
+ int version = 0;
+ while (*p && p < end) {
+ if (*p == '#') {
+ /* skip comment line */
+ while (*p != '\n' && p < end) {
+ p++;
+ }
+ p++;
+ continue;
+ }
+ if (*p == ' ') {
+ while (*p == ' ' && p < end) {
+ p++;
+ }
+ /* only accept blank lines before 'version=' line */
+ if (*p != '\n') {
+ return 0;
+ }
+ p++;
+ continue;
+ }
+ sscanf(p, "version=%d", &version);
+ if (version == 1 || version == 2) {
+ return 100;
+ } else {
+ return 0;
+ }
+ }
+ }
+ return 0;
}
#define CHECK_CID 1
next prev parent reply other threads:[~2011-06-24 8:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 8:18 [Qemu-devel] [PATCH v2 00/12] Adding VMDK monolithic flat support famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 01/12] VMDK: introduce VmdkExtent famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster famcool
2011-06-24 8:18 ` famcool [this message]
2011-06-24 9:56 ` [Qemu-devel] [PATCH v2 03/12] VMDK: probe for monolithicFlat images Stefan Hajnoczi
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 04/12] VMDK: separate vmdk_open by format version famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 05/12] VMDK: add field BDRVVmdkState.desc_offset famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 06/12] VMDK: flush multiple extents famcool
2011-06-24 9:58 ` Stefan Hajnoczi
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 07/12] VMDK: move 'static' cid_update flag to bs field famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 08/12] VMDK: change get_cluster_offset return type famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 09/12] VMDK: open/read/write for monolithicFlat image famcool
2011-06-24 10:11 ` Stefan Hajnoczi
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 10/12] VMDK: create different subformats famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 11/12] VMDK: fix coding style famcool
2011-06-24 8:18 ` [Qemu-devel] [PATCH v2 12/12] BlockDriver: add bdrv_get_allocated_file_size() operation famcool
2011-06-24 8:24 ` [Qemu-devel] [PATCH v2 00/12] Adding VMDK monolithic flat support Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308903507-10799-4-git-send-email-famcool@gmail.com \
--to=famcool@gmail.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).